Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 580353002: mojo: Fix crash in example WM when closing window. (Closed)

Created:
6 years, 3 months ago by Daniel Erat
Modified:
6 years, 3 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

mojo: Fix crash in example WM when closing window. Avoid a crash caused by dereferencing an iterator after erasing it. BUG=415816 Committed: https://crrev.com/de4d067f40fa7d1b89cf77b0d3c642306569b47a Cr-Commit-Position: refs/heads/master@{#295718}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M mojo/examples/window_manager/window_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Daniel Erat
6 years, 3 months ago (2014-09-19 00:35:25 UTC) #2
Aaron Boodman
Very gracious of you to not mention that I assigned you a bug that I ...
6 years, 3 months ago (2014-09-19 00:39:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/580353002/1
6 years, 3 months ago (2014-09-19 00:41:54 UTC) #5
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-19 06:43:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/580353002/1
6 years, 3 months ago (2014-09-19 15:39:44 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as ecef251ad56bb1121c8de5a8944a979dfd695a19
6 years, 3 months ago (2014-09-19 16:15:33 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 16:16:14 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/de4d067f40fa7d1b89cf77b0d3c642306569b47a
Cr-Commit-Position: refs/heads/master@{#295718}

Powered by Google App Engine
This is Rietveld 408576698