mojo/examples/window_manager/window_manager.cc - Issue 580353002: mojo: Fix crash in example WM when closing window.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/examples/window_manager/window_manager.cc

Issue 580353002: mojo: Fix crash in example WM when closing window. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/examples/window_manager/window_manager.cc

diff --git a/mojo/examples/window_manager/window_manager.cc b/mojo/examples/window_manager/window_manager.cc

index d0e6d82a67b4f08a44bd893b4f46725bd79208aa..f2167afde0465947dbf460e12c44e4e978150331 100644

--- a/mojo/examples/window_manager/window_manager.cc

+++ b/mojo/examples/window_manager/window_manager.cc

@@ -299,8 +299,9 @@ class WindowManager

void CloseWindow(Id view_id) {

WindowVector::iterator iter = GetWindowByViewId(view_id);

DCHECK(iter != windows_.end());

+ Window* window = *iter;

windows_.erase(iter);

- (*iter)->view()->Destroy();

+ window->view()->Destroy();

}

void ShowKeyboard(Id view_id, const gfx::Rect& bounds) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »