Interface change for net_util.h for WebRTC IPv6 support.

Interface change for net_util.h for WebRTC IPv6 support.

Migrated from https://codereview.chromium.org/538243003/ as it was created under wrong identity.

Committed: https://crrev.com/45d667c5e960ef7a60a70b74251c746c5d8168de
Cr-Commit-Position: refs/heads/master@{#296068}

[guoweis2, 2014-09-18 21:05:14]

guoweis@google.com changed reviewers:
+ guoweis@google.com, pauljensen@chromium.org

[guoweis2, 2014-09-18 21:05:14]

@pauljensen. PTAL. fixed issues you mentioned.

I am abandoning the previous CL https://codereview.chromium.org/538243003/ as it
was created under wrong identity. 

Sorry for the inconvenience.

[pauljensen, 2014-09-19 14:56:53]

I think the description could use some capitalization too.

https://codereview.chromium.org/580283002/diff/1/net/base/net_util.h
File net/base/net_util.h (right):

https://codereview.chromium.org/580283002/diff/1/net/base/net_util.h#newcode441
net/base/net_util.h:441: // A subset of IP address attributes which are
actionable by
by->by the
(I recommended this in my last review)

https://codereview.chromium.org/580283002/diff/1/net/base/net_util.h#newcode447
net/base/net_util.h:447: // Temporary address is dynamic by nature and will not
carry MAC
carry -> contain
Could we mention this is for IPv6 privacy and reference rfc4941.

https://codereview.chromium.org/580283002/diff/1/net/base/net_util.h#newcode451
net/base/net_util.h:451: // Temporary address could become deprecated once the
preferred
Either "Temporary" -> "A temporary"
or "address could" -> "addresses can"

https://codereview.chromium.org/580283002/diff/1/net/base/net_util.h#newcode453
net/base/net_util.h:453: // create new connection.
connection -> connections

https://codereview.chromium.org/580283002/diff/1/net/base/net_util.h#newcode461
net/base/net_util.h:461: 
needless whitespace change

[guoweis2, 2014-09-19 16:55:30]

guoweis@google.com changed reviewers:
+ jam@chromium.org, marq@chromium.org

[guoweis2, 2014-09-19 16:55:31]

@pauljensen: Please review the change from early comments.

Context for the reviewers below: Adding a parameter in NetworkInterface
constructor which contains the address attributes. Enum definition inside
net_util.h.

jam@chromium.org: Please OWNER review changes in dial_service_unittest.cc &
privet_traffic_detector.cc.

marq@chromium.org: Please OWNER review changes in
data_reduction_proxy_settings_unittest.cc.

wfh@chromium.org: Please OWNER review change in p2p_message.h.

https://codereview.chromium.org/580283002/diff/1/net/base/net_util.h
File net/base/net_util.h (right):

https://codereview.chromium.org/580283002/diff/1/net/base/net_util.h#newcode441
net/base/net_util.h:441: // A subset of IP address attributes which are
actionable by
On 2014/09/19 14:56:53, pauljensen wrote:
> by->by the
> (I recommended this in my last review)

Sorry, missed the. Done.

https://codereview.chromium.org/580283002/diff/1/net/base/net_util.h#newcode447
net/base/net_util.h:447: // Temporary address is dynamic by nature and will not
carry MAC
On 2014/09/19 14:56:53, pauljensen wrote:
> carry -> contain
> Could we mention this is for IPv6 privacy and reference rfc4941.

Done.

https://codereview.chromium.org/580283002/diff/1/net/base/net_util.h#newcode451
net/base/net_util.h:451: // Temporary address could become deprecated once the
preferred
On 2014/09/19 14:56:53, pauljensen wrote:
> Either "Temporary" -> "A temporary"
> or "address could" -> "addresses can"

Done.

https://codereview.chromium.org/580283002/diff/1/net/base/net_util.h#newcode453
net/base/net_util.h:453: // create new connection.
On 2014/09/19 14:56:53, pauljensen wrote:
> connection -> connections

Done.

https://codereview.chromium.org/580283002/diff/1/net/base/net_util.h#newcode461
net/base/net_util.h:461: 
On 2014/09/19 14:56:53, pauljensen wrote:
> needless whitespace change

Done. Also removed one before ~NetworkInterface()

[guoweis2, 2014-09-19 16:56:58]

guoweis@google.com changed reviewers:
+ wfh@chromium.org

[guoweis2, 2014-09-19 16:56:58]

Context for the OWNER reviewers: Adding a parameter in NetworkInterface
constructor which contains the address attributes. Enum definition inside
net_util.h.

jam@chromium.org: Please OWNER review changes in dial_service_unittest.cc &
privet_traffic_detector.cc.

marq@chromium.org: Please OWNER review changes in
data_reduction_proxy_settings_unittest.cc.

wfh@chromium.org: Please OWNER review change in p2p_message.h.

[Will Harris, 2014-09-19 17:08:57]

lgtm for content/common/p2p_messages.h

[pauljensen, 2014-09-19 17:50:55]

lgtm for net/

[guoweis_left_chromium, 2014-09-22 06:38:47]

guoweis@chromium.org changed reviewers:
- guoweis@google.com, pauljensen@chromium.org, wfh@chromium.org

[guoweis_left_chromium, 2014-09-22 06:38:48]

@jam and @marq, please OWNER review the CL.

[jam, 2014-09-22 17:35:03]

lgtm

[marq (ping after 24h), 2014-09-22 18:37:31]

/components/data_reduction_proxy/ LGTM

+cc bengr@

[guoweis2, 2014-09-22 19:52:30]

The CQ bit was checked by guoweis@google.com

[commit-bot: I haz the power, 2014-09-22 19:53:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/580283002/20001

[commit-bot: I haz the power, 2014-09-22 20:14:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-22 20:14:02]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)

[guoweis2, 2014-09-22 20:32:53]

guoweis@google.com changed reviewers:
+ sergeyu@chromium.org
- jam@chromium.org, marq@chromium.org

[guoweis2, 2014-09-22 20:32:54]

@sergeyu: please OWNER review ipc_network_manager_unittest.cc

[Sergey Ulanov, 2014-09-22 21:00:08]

lgtm

[guoweis2, 2014-09-22 21:00:25]

The CQ bit was checked by guoweis@google.com

[commit-bot: I haz the power, 2014-09-22 21:01:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/580283002/40001

[commit-bot: I haz the power, 2014-09-22 22:19:43]

Committed patchset #3 (id:40001) as 8c63b19c39d8aabb683ba71472fa1069aad69ebd

[commit-bot: I haz the power, 2014-09-22 22:20:34]

Patchset 3 (id:??) landed as
https://crrev.com/45d667c5e960ef7a60a70b74251c746c5d8168de
Cr-Commit-Position: refs/heads/master@{#296068}