Interface change for net_util.h for WebRTC IPv6 support.

net/base/net_util.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_BASE_NET_UTIL_H_
 #define NET_BASE_NET_UTIL_H_
 
 #include "build/build_config.h"
 
 #if defined(OS_WIN)
@@ skipping 420 matching lines @@
                                            socklen_t address_len);
 
 // Returns true if |host| is one of the names (e.g. "localhost") or IP
 // addresses (IPv4 127.0.0.0/8 or IPv6 ::1) that indicate a loopback.
 //
 // Note that this function does not check for IP addresses other than
 // the above, although other IP addresses may point to the local
 // machine.
 NET_EXPORT_PRIVATE bool IsLocalhost(const std::string& host);
 
+// A subset of IP address attributes which are actionable by

[pauljensen, 2014/09/19 14:56:53]

by->by the
(I recommended this in my last review)

[guoweis2, 2014/09/19 16:55:30]

Sorry, missed the. Done.

+// application layer. Currently unimplemented for all hosts;
+// IP_ADDRESS_ATTRIBUTE_NONE is always returned.
+enum IPAddressAttributes {
+  IP_ADDRESS_ATTRIBUTE_NONE = 0,
+
+  // Temporary address is dynamic by nature and will not carry MAC

[pauljensen, 2014/09/19 14:56:53]

carry -> contain
Could we mention this is for IPv6 privacy and reference rfc4941.

[guoweis2, 2014/09/19 16:55:30]

Done.

+  // address.
+  IP_ADDRESS_ATTRIBUTE_TEMPORARY = 1 << 0,
+
+  // Temporary address could become deprecated once the preferred

[pauljensen, 2014/09/19 14:56:53]

Either "Temporary" -> "A temporary"
or "address could" -> "addresses can"

[guoweis2, 2014/09/19 16:55:30]

Done.

+  // lifetime is reached. It is still valid but shouldn't be used to
+  // create new connection.

[pauljensen, 2014/09/19 14:56:53]

connection -> connections

[guoweis2, 2014/09/19 16:55:30]

Done.

+  IP_ADDRESS_ATTRIBUTE_DEPRECATED = 1 << 1,
+};
+
 // struct that is used by GetNetworkList() to represent a network
 // interface.
 struct NET_EXPORT NetworkInterface {
   NetworkInterface();
+

[pauljensen, 2014/09/19 14:56:53]

needless whitespace change

[guoweis2, 2014/09/19 16:55:30]

Done. Also removed one before ~NetworkInterface()

   NetworkInterface(const std::string& name,
                    const std::string& friendly_name,
                    uint32 interface_index,
                    NetworkChangeNotifier::ConnectionType type,
                    const IPAddressNumber& address,
-                   uint32 network_prefix);
+                   uint32 network_prefix,
+                   int ip_address_attributes);
+
   ~NetworkInterface();
 
   std::string name;
   std::string friendly_name;  // Same as |name| on non-Windows.
   uint32 interface_index;  // Always 0 on Android.
   NetworkChangeNotifier::ConnectionType type;
   IPAddressNumber address;
   uint32 network_prefix;
+  int ip_address_attributes;  // Combination of |IPAddressAttributes|.
 };
 
 typedef std::vector<NetworkInterface> NetworkInterfaceList;
 
 // Policy settings to include/exclude network interfaces.
 enum HostAddressSelectionPolicy {
   INCLUDE_HOST_SCOPE_VIRTUAL_INTERFACES           = 0x0,
   EXCLUDE_HOST_SCOPE_VIRTUAL_INTERFACES           = 0x1,
   // Include temp address only when interface has both permanent and
   // temp addresses.
@@ skipping 62 matching lines @@
   DSCP_CS5  = 40,  // Video
   DSCP_EF   = 46,  // Voice
   DSCP_CS6  = 48,  // Voice
   DSCP_CS7  = 56,  // Control messages
   DSCP_LAST = DSCP_CS7
 };
 
 }  // namespace net
 
 #endif  // NET_BASE_NET_UTIL_H_