Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: chrome/browser/extensions/api/notifications/notifications_api.cc

Issue 580243004: Remove unnecessary image downloading handler of notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/notifications/notifications_api.cc
diff --git a/chrome/browser/extensions/api/notifications/notifications_api.cc b/chrome/browser/extensions/api/notifications/notifications_api.cc
index 631dbf4b219164e35619178184d2440805a7cc69..785f09ea8e53bb8009c3f21887598e8e850d188c 100644
--- a/chrome/browser/extensions/api/notifications/notifications_api.cc
+++ b/chrome/browser/extensions/api/notifications/notifications_api.cc
@@ -122,23 +122,6 @@ class NotificationsApiDelegate : public NotificationDelegate {
return scoped_id_;
}
- virtual content::WebContents* GetWebContents() const OVERRIDE {
- // We're holding a reference to api_function_, so we know it'll be valid
- // until ReleaseRVH is called, and api_function_ (as a
- // AsyncExtensionFunction) will zero out its copy of render_view_host
- // when the RVH goes away.
- if (!api_function_.get())
- return NULL;
- content::RenderViewHost* rvh = api_function_->render_view_host();
- if (!rvh)
- return NULL;
- return content::WebContents::FromRenderViewHost(rvh);
- }
-
- virtual void ReleaseRenderViewHost() OVERRIDE {
- api_function_ = NULL;
- }
-
private:
virtual ~NotificationsApiDelegate() {}

Powered by Google App Engine
This is Rietveld 408576698