chrome/browser/notifications/desktop_notification_service.cc - Issue 580243004: Remove unnecessary image downloading handler of notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/desktop_notification_service.cc

Issue 580243004: Remove unnecessary image downloading handler of notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/local_discovery/privet_notifications.cc ('k') | chrome/browser/notifications/extension_welcome_notification_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/desktop_notification_service.cc

diff --git a/chrome/browser/notifications/desktop_notification_service.cc b/chrome/browser/notifications/desktop_notification_service.cc

index ca8770c9e98a631726ad539c8341635cbe4fba9b..598703410964f410b459c1404060aaa6c4928415 100644

--- a/chrome/browser/notifications/desktop_notification_service.cc

+++ b/chrome/browser/notifications/desktop_notification_service.cc

@@ -158,8 +158,7 @@ void DesktopNotificationService::ShowDesktopNotification(

base::Closure* cancel_callback) {

DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

const GURL& origin = params.origin;

- NotificationObjectProxy* proxy =

- new NotificationObjectProxy(render_frame_host, delegate.Pass());

+ NotificationObjectProxy* proxy =new NotificationObjectProxy(delegate.Pass());

oshima 2014/09/21 15:26:01 nit: space after =

Jun Mukai 2014/09/22 18:54:37 Done.

base::string16 display_source = DisplayNameForOriginInProcessId(

origin, render_frame_host->GetProcess()->GetID());