Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1146)

Unified Diff: chrome/browser/notifications/desktop_notification_service.h

Issue 580093003: Factor Google Now welcome notifications out of DesktopNotificationService. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/notifications/desktop_notification_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/notifications/desktop_notification_service.h
diff --git a/chrome/browser/notifications/desktop_notification_service.h b/chrome/browser/notifications/desktop_notification_service.h
index 62f51c0356778baf7ca450ee03b1faeba2cdeab8..d68e965b907291d3077f41bc67bf50b52981a363 100644
--- a/chrome/browser/notifications/desktop_notification_service.h
+++ b/chrome/browser/notifications/desktop_notification_service.h
@@ -18,7 +18,6 @@
#include "base/scoped_observer.h"
#include "base/strings/string16.h"
#include "chrome/browser/content_settings/permission_context_base.h"
-#include "chrome/browser/notifications/extension_welcome_notification.h"
#include "components/content_settings/core/common/content_settings.h"
#include "components/keyed_service/core/keyed_service.h"
#include "third_party/WebKit/public/platform/WebNotificationPermission.h"
@@ -108,10 +107,6 @@ class DesktopNotificationService : public PermissionContextBase
void SetNotifierEnabled(const message_center::NotifierId& notifier_id,
bool enabled);
- // Adds in a the welcome notification if required for components built
- // into Chrome that show notifications like Chrome Now.
- void ShowWelcomeNotificationIfNecessary(const Notification& notification);
-
private:
// Returns a display name for an origin in the process id, to be used in
// permission infobar or on the frame of the notification toast. Different
@@ -171,9 +166,6 @@ class DesktopNotificationService : public PermissionContextBase
extension_registry_observer_;
#endif
- // Welcome Notification
- scoped_ptr<ExtensionWelcomeNotification> chrome_now_welcome_notification_;
-
base::WeakPtrFactory<DesktopNotificationService> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(DesktopNotificationService);
« no previous file with comments | « no previous file | chrome/browser/notifications/desktop_notification_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698