Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(862)

Unified Diff: chrome/browser/notifications/desktop_notification_service.cc

Issue 580093003: Factor Google Now welcome notifications out of DesktopNotificationService. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/desktop_notification_service.cc
diff --git a/chrome/browser/notifications/desktop_notification_service.cc b/chrome/browser/notifications/desktop_notification_service.cc
index 9e5c388c9a7d95152acce6a6327b8066ba3c17d6..b05d1df49648913f2c64756f88b65f9680cbfb87 100644
--- a/chrome/browser/notifications/desktop_notification_service.cc
+++ b/chrome/browser/notifications/desktop_notification_service.cc
@@ -55,8 +55,6 @@ using message_center::NotifierId;
namespace {
-const char kChromeNowExtensionID[] = "pafkbggdmjlpgkdkcbjmhmfcdpncadgh";
-
void CancelNotification(const std::string& id) {
g_browser_process->notification_ui_manager()->CancelById(id);
}
@@ -74,7 +72,6 @@ void DesktopNotificationService::RegisterProfilePrefs(
registry->RegisterListPref(
prefs::kMessageCenterDisabledSystemComponentIds,
user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
- ExtensionWelcomeNotification::RegisterProfilePrefs(registry);
}
// static
@@ -271,19 +268,6 @@ void DesktopNotificationService::SetNotifierEnabled(
}
}
-void DesktopNotificationService::ShowWelcomeNotificationIfNecessary(
- const Notification& notification) {
- if (!chrome_now_welcome_notification_) {
- chrome_now_welcome_notification_ =
- ExtensionWelcomeNotification::Create(kChromeNowExtensionID, profile_);
- }
-
- if (chrome_now_welcome_notification_) {
- chrome_now_welcome_notification_->ShowWelcomeNotificationIfNecessary(
- notification);
- }
-}
-
void DesktopNotificationService::OnStringListPrefChanged(
const char* pref_name, std::set<std::string>* ids_field) {
ids_field->clear();

Powered by Google App Engine
This is Rietveld 408576698