Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6778)

Unified Diff: chrome/common/metrics/proto/omnibox_event.proto

Issue 58003005: Modify Entity Suggestion support and Add Profile Suggest support (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed classifications from server Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/metrics/proto/omnibox_event.proto
diff --git a/chrome/common/metrics/proto/omnibox_event.proto b/chrome/common/metrics/proto/omnibox_event.proto
index c883f997d0162d8166fc808614571551eee3e388..145e597528fbf8889648efa9df1aed4579e6449c 100644
--- a/chrome/common/metrics/proto/omnibox_event.proto
+++ b/chrome/common/metrics/proto/omnibox_event.proto
@@ -170,6 +170,12 @@ message OmniboxEventProto {
// contains the input
CONTACT = 12; // One of the user's contacts
BOOKMARK_TITLE = 13; // A bookmark whose title contains the input.
+ SEARCH_SUGGEST_ENTITY = 14; // A suggested search for an entity.
+ SEARCH_SUGGEST_INFINITE = 15; // A suggested search to complete the tail
+ // of the query.
+ SEARCH_SUGGEST_PERSONALIZED = 16; // A personalized suggested search.
+ SEARCH_SUGGEST_PROFILE = 17; // A personalized suggested search for a
+ // Google+ profile.
Ilya Sherman 2013/12/10 01:28:23 What does SEARCH_SUGGEST now entail? Is that buck
Anuj 2013/12/10 01:39:45 Meaning of SEARCH_SUGGEST doesn't change. Although
Peter Kasting 2013/12/10 03:52:30 Don't rename SEARCH_SUGGEST, but do update the com
Mark P 2013/12/10 15:10:18 +1 to this suggestion. And, when this is resolved
Anuj 2013/12/10 23:08:09 Done.
Anuj 2013/12/10 23:08:09 Done.
}
optional ResultType result_type = 2;
« chrome/browser/autocomplete/search_provider.cc ('K') | « chrome/common/autocomplete_match_type.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698