Modify Entity Suggestion support and Add Profile Suggest support

chrome/common/metrics/proto/omnibox_event.proto

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Stores information about an omnibox interaction.
 
 syntax = "proto2";
 
 option optimize_for = LITE_RUNTIME;
 
@@ skipping 152 matching lines @@
                                   // default engine)
       SEARCH_HISTORY = 8;         // A past search (with the default engine)
                                   // containing the input
       SEARCH_SUGGEST = 9;         // A suggested search (with the default
                                   // engine)
       SEARCH_OTHER_ENGINE = 10;   // A search with a non-default engine
       EXTENSION_APP = 11;         // An Extension App with a title/url that
                                   // contains the input
       CONTACT = 12;               // One of the user's contacts
       BOOKMARK_TITLE = 13;        // A bookmark whose title contains the input.
+      SEARCH_SUGGEST_ENTITY = 14; // A suggested search for an entity.
+      SEARCH_SUGGEST_INFINITE = 15; // A suggested search to complete the tail
+                                    // of the query.
+      SEARCH_SUGGEST_PERSONALIZED = 16; // A personalized suggested search.
+      SEARCH_SUGGEST_PROFILE = 17; // A personalized suggested search for a
+                                   // Google+ profile.      

[Ilya Sherman, 2013/12/10 01:28:23]

What does SEARCH_SUGGEST now entail?  Is that bucket deprecated?  Please
document within this proto file.

[Anuj, 2013/12/10 01:39:45]

Meaning of SEARCH_SUGGEST doesn't change. Although I can rename it to
SEARCH_SUGGEST_QUERY if you want. These suggestion types are newly being added
to Chrome omnibox.

[Peter Kasting, 2013/12/10 03:52:30]

Don't rename SEARCH_SUGGEST, but do update the comments here and in
autocomplete_match_type.h to add "...that doesn't fall into one of the more
specific suggestion categories below" to its description.

[Mark P, 2013/12/10 15:10:18]

+1 to this suggestion.

And, when this is resolved, please make sure the internal google file is
identical (i.e., same comment, formatting, etc.)

And also please try to keep the autocomplete_match_type comments in sync with
this as well.  (formatting not important, but content should be equivalent)

[Anuj, 2013/12/10 23:08:09]

Done.

[Anuj, 2013/12/10 23:08:09]

Done.

     }
     optional ResultType result_type = 2;
 
     // The relevance score for this suggestion.
     optional int32 relevance = 3;
 
     // How many times this result was typed in / selected from the omnibox.
     // Only set for some providers and result_types.  At the time of
     // writing this comment, it is only set for HistoryURL and
     // HistoryQuickProvider matches.
@@ skipping 29 matching lines @@
     // See AutocompleteController::ResetSession() for more details on the
     // definition of a session.
     // See chrome/browser/autocomplete/search_provider.cc for a specific usage
     // example.
     repeated fixed32 field_trial_triggered_in_session = 4;
   }
   // A list of diagnostic information about each provider.  Providers
   // will appear at most once in this list.
   repeated ProviderInfo provider_info = 12;
 }