Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(39)

Issue 5800002: Merge 73697 - 2010-12-10 Hans Wennborg <hans@chromium.org>... (Closed)

Created:
8 years, 6 months ago by hans
Modified:
7 years, 11 months ago
Reviewers:
hans
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/597/
Visibility:
Public.

Description

Merge 73697 - 2010-12-10 Hans Wennborg <hans@chromium.org>; Reviewed by Jeremy Orlow. IndexedDB: Numeric keys are floats. https://bugs.webkit.org/show_bug.cgi?id=50674 Update layout tests to use floating-point values for keys. * storage/indexeddb/keyrange-expected.txt: * storage/indexeddb/keyrange.html: Make sure creating the keys works. * storage/indexeddb/objectstore-cursor-expected.txt: * storage/indexeddb/objectstore-cursor.html: Make sure retrieving the keys from the DB objectstore works. 2010-12-10 Hans Wennborg <hans@chromium.org>; Reviewed by Jeremy Orlow. IndexedDB: Numeric keys are floats. https://bugs.webkit.org/show_bug.cgi?id=50674 Use floating point to represent numeric keys, add version meta data to the SQLite db, and migrate object stores that use integers. * bindings/v8/IDBBindingUtilities.cpp: (WebCore::createIDBKeyFromValue): * bindings/v8/custom/V8IDBKeyCustom.cpp: (WebCore::toV8): * storage/IDBFactoryBackendImpl.cpp: (WebCore::createTables): (WebCore::migrateDatabase): (WebCore::IDBFactoryBackendImpl::open): * storage/IDBKey.cpp: (WebCore::IDBKey::IDBKey): (WebCore::IDBKey::fromQuery): (WebCore::IDBKey::bind): (WebCore::IDBKey::bindWithNulls): * storage/IDBKey.h: (WebCore::IDBKey::create): (WebCore::IDBKey::number): 2010-12-10 Hans Wennborg <hans@chromium.org>; Reviewed by Jeremy Orlow. IndexedDB: Numeric keys are floats. https://bugs.webkit.org/show_bug.cgi?id=50674 Represent numeric keys as floating point values. * public/WebIDBKey.h: (WebKit::WebIDBKey::WebIDBKey): * src/WebIDBKey.cpp: (WebKit::WebIDBKey::assign): (WebKit::WebIDBKey::number): TBR=hans@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=73902

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1528 lines, -39 lines) Patch
M LayoutTests/ChangeLog View 1 chunk +17 lines, -1 line 0 comments Download
M LayoutTests/storage/indexeddb/index-basics.html View 4 chunks +14 lines, -2 lines 0 comments Download
M LayoutTests/storage/indexeddb/index-basics-expected.txt View 4 chunks +21 lines, -2 lines 0 comments Download
M LayoutTests/storage/indexeddb/index-cursor.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/storage/indexeddb/keyrange.html View 3 chunks +13 lines, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/keyrange-expected.txt View 4 chunks +60 lines, -0 lines 0 comments Download
M LayoutTests/storage/indexeddb/objectstore-cursor.html View 1 chunk +2 lines, -2 lines 0 comments Download
M WebCore/ChangeLog View 1 chunk +1051 lines, -0 lines 0 comments Download
M WebCore/bindings/v8/IDBBindingUtilities.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M WebCore/bindings/v8/custom/V8IDBKeyCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M WebCore/storage/IDBFactoryBackendImpl.cpp View 5 chunks +95 lines, -14 lines 0 comments Download
M WebCore/storage/IDBKey.h View 3 chunks +4 lines, -4 lines 0 comments Download
M WebCore/storage/IDBKey.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M WebKit/chromium/ChangeLog View 1 chunk +237 lines, -0 lines 0 comments Download
M WebKit/chromium/public/WebIDBKey.h View 3 chunks +3 lines, -3 lines 0 comments Download
M WebKit/chromium/src/WebIDBKey.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
hans
8 years, 6 months ago (2010-12-13 12:23:21 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698