Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(899)

Side by Side Diff: WebCore/ChangeLog

Issue 5800002: Merge 73697 - 2010-12-10 Hans Wennborg <hans@chromium.org>... (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/597/
Patch Set: Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 2010-12-10 Hans Wennborg <hans@chromium.org>
2
3 Reviewed by Jeremy Orlow.
4
5 IndexedDB: Numeric keys are floats.
6 https://bugs.webkit.org/show_bug.cgi?id=50674
7
8 Use floating point to represent numeric keys,
9 add version meta data to the SQLite db,
10 and migrate object stores that use integers.
11
12 * bindings/v8/IDBBindingUtilities.cpp:
13 (WebCore::createIDBKeyFromValue):
14 * bindings/v8/custom/V8IDBKeyCustom.cpp:
15 (WebCore::toV8):
16 * storage/IDBFactoryBackendImpl.cpp:
17 (WebCore::createTables):
18 (WebCore::migrateDatabase):
19 (WebCore::IDBFactoryBackendImpl::open):
20 * storage/IDBKey.cpp:
21 (WebCore::IDBKey::IDBKey):
22 (WebCore::IDBKey::fromQuery):
23 (WebCore::IDBKey::bind):
24 (WebCore::IDBKey::bindWithNulls):
25 * storage/IDBKey.h:
26 (WebCore::IDBKey::create):
27 (WebCore::IDBKey::number):
28
29 2010-12-10 Martin Robinson <mrobinson@igalia.com>
30
31 Reviewed by Xan Lopez.
32
33 [Gtk] style="font-family: courier" makes text disappear
34 https://bugs.webkit.org/show_bug.cgi?id=47452
35
36 Don't ever use fonts that do not have any of the three charmaps that
37 Fontconfig supports (Unicode, Apple Roman and Symbol). If we select
38 a font that doesn't have one of these charmaps, use the next font in
39 the list.
40
41 Test: platform/gtk/fonts/font-with-no-valid-encoding.html
42
43 * platform/graphics/freetype/FontCacheFreeType.cpp:
44 (WebCore::FontCache::createFontPlatformData): Check whether the
45 font we selected has a valid Fontconfig charmap.
46 * platform/graphics/freetype/FontPlatformData.h: Added new method defini tion.
47 * platform/graphics/freetype/FontPlatformDataFreeType.cpp:
48 (WebCore::FontPlatformData::hasCompatibleCharmap): Added this method whi ch
49 verifies that a font has a valid Fontconfig charmap.
50
51 2010-12-09 Ryosuke Niwa <rniwa@webkit.org>
52
53 Reviewed by Ojan Vafai.
54
55 Make DOM Mutation Events Asynchronous
56 https://bugs.webkit.org/show_bug.cgi?id=46936
57
58 Implemented DOM mutations events as scoped events. A scoped event is an event whose
59 dispatch is done via ScopedEventQueue. The behavior of the queue is cont rolled by
60 EventQueueScope objects (RAII idiom), which increments and decrements th e scoping level
61 on its constructor and destructor respectively.
62
63 When the scoping level is 0 (initial level), scoped events are dispatche d as soon as
64 they are enqueued and act like synchronous events. When the scoping leve l is greater than 0,
65 however, events are queued in ScopedEventQueue and their dispatches are delayed until
66 the scoping level goes back to 0 (by the destruction of EventQueueScope) .
67
68 DOMSubtreeModified, DOMNodeInserted, DOMNodeRemoved, DOMNodeRemovedFromD ocument,
69 DOMNodeInsertedIntoDocument, DOMFocusIn, DOMFocusOut, focusin, and focus out are treated as
70 scoped events, and a scope object is instantiated in EditCommand::apply to delay dispatches
71 of the events until the completion of each call of EditCommand::doApply.
72
73 Test: fast/events/mutation/execCommands.html
74
75 * Android.mk: Added ScopedEventQueue.cpp.
76 * CMakeLists.txt: Ditto.
77 * WebCore.pro: Ditto.
78 * GNUmakefile.am: Added ScopedEventQueue.cpp and ScopedEventQueue.h.
79 * WebCore.gypi: Ditto.
80 * WebCore.vcproj/project.vcproj: Ditto.
81 * WebCore.xcodeproj/project.pbxproj: Ditto.
82 * dom/ContainerNode.cpp:
83 (WebCore::dispatchChildInsertionEvents): Calls dispatchScopedEvent.
84 (WebCore::dispatchChildRemovalEvents): Ditto.
85 * dom/DOMAllInOne.cpp: Added ScopedEventQueue.cpp.
86 * dom/Element.cpp:
87 (WebCore::Element::dispatchAttrRemovalEvent): Ditto.
88 (WebCore::Element::dispatchAttrAdditionEvent): Ditto.
89 * dom/Node.cpp:
90 (WebCore::Node::dispatchScopedEvent): Added.
91 (WebCore::Node::dispatchSubtreeModifiedEvent): Calls dispatchScopedEvent .
92 * dom/Node.h:
93 * dom/ScopedEventQueue.cpp: Added.
94 (WebCore::ScopedEventQueue::initialize): Added.
95 (WebCore::ScopedEventQueue::enqueueEvent): Added.
96 (WebCore::ScopedEventQueue::dispatchAllEvents): Added.
97 (WebCore::ScopedEventQueue::dispatchEvent): Added.
98 (WebCore::ScopedEventQueue::instance): Added.
99 (WebCore::ScopedEventQueue::incrementScopingLevel): Added.
100 (WebCore::ScopedEventQueue::decrementScopingLevel): Added.
101 * dom/ScopedEventQueue.h: Added.
102 (WebCore::ScopedEventQueue::~ScopedEventQueue): Added.
103 (WebCore::ScopedEventQueue::ScopedEventQueue): Added.
104 (WebCore::EventQueueScope::EventQueueScope): Added.
105 (WebCore::EventQueueScope::~EventQueueScope): Added.
106 * editing/EditCommand.cpp:
107 (WebCore::EditCommand::apply): Instantiates EventQueueScope.
108
109 2010-12-09 Sheriff Bot <webkit.review.bot@gmail.com>
110
111 Unreviewed, rolling out r73684.
112 http://trac.webkit.org/changeset/73684
113 https://bugs.webkit.org/show_bug.cgi?id=50801
114
115 "missing bug number" (Requested by rniwa on #webkit).
116
117 * Android.mk:
118 * CMakeLists.txt:
119 * GNUmakefile.am:
120 * WebCore.gypi:
121 * WebCore.pro:
122 * WebCore.vcproj/WebCore.vcproj:
123 * WebCore.xcodeproj/project.pbxproj:
124 * dom/ContainerNode.cpp:
125 (WebCore::dispatchChildInsertionEvents):
126 (WebCore::dispatchChildRemovalEvents):
127 * dom/DOMAllInOne.cpp:
128 * dom/Element.cpp:
129 (WebCore::Element::dispatchAttrRemovalEvent):
130 (WebCore::Element::dispatchAttrAdditionEvent):
131 * dom/Node.cpp:
132 (WebCore::Node::dispatchSubtreeModifiedEvent):
133 (WebCore::Node::dispatchUIEvent):
134 * dom/Node.h:
135 * dom/ScopedEventQueue.cpp: Removed.
136 * dom/ScopedEventQueue.h: Removed.
137 * editing/EditCommand.cpp:
138 (WebCore::EditCommand::apply):
139
140 2010-12-09 Qi Zhang <qi.2.zhang@nokia.com>
141
142 Reviewed by Kenneth Rohde Christiansen.
143
144 [Qt] enable orientation flag when QtMobility available
145 https://bugs.webkit.org/show_bug.cgi?id=50781
146
147 When QtMobility available, enable orientation flag by default.
148
149 * features.pri:
150
151 2010-12-09 Kenichi Ishibashi <bashi@google.com>
152
153 Reviewed by Kent Tamura.
154
155 Improve validation API support of <object> and <keygen>
156 https://bugs.webkit.org/show_bug.cgi?id=50663
157
158 Adds validation API to HTMLObjectElement class.
159 Makes HTMLKeygenElement::willValidate() return false.
160
161 Test: fast/forms/setCustomValidity-existence.html
162
163 * html/HTMLKeygenElement.h:
164 (WebCore::HTMLKeygenElement::willValidate): Added.
165 * html/HTMLObjectElement.h:
166 (WebCore::HTMLObjectElement::validationMessage): Added.
167 (WebCore::HTMLObjectElement::checkValidity): Added.
168 (WebCore::HTMLObjectElement::setCustomValidity): Added.
169 * html/HTMLObjectElement.idl: Added validation API properties.
170
171 2010-12-09 Sadrul Habib Chowdhury <sadrul@chromium.org>
172
173 Reviewed by Kent Tamura.
174
175 Make sure a non-zero value is used for tile-width to avoid a crash
176 https://bugs.webkit.org/show_bug.cgi?id=50341
177
178 The scaled tile width can be very small at times (e.g. with 'style: font 1
179 required'). So use a minimum width of 1 instead of using 0 (which leads to a
180 crash).
181
182 Tests: fast/dom/HTMLProgressElement/progress-element-with-style-crash.ht ml
183
184 * rendering/RenderThemeChromiumSkia.cpp:
185 (WebCore::RenderThemeChromiumSkia::paintProgressBar):
186
187 2010-12-09 Ryosuke Niwa <rniwa@webkit.org>
188
189 Reviewed by Ojan Vafai.
190
191 Implemented DOM mutations events as scoped events. A scoped event is an event whose
192 dispatch is done via ScopedEventQueue. The behavior of the queue is cont rolled by
193 EventQueueScope objects (RAII idiom), which increments and decrements th e scoping level
194 on its constructor and destructor respectively.
195
196 When the scoping level is 0 (initial level), scoped events are dispatche d as soon as
197 they are enqueued and act like synchronous events. When the scoping leve l is greater than 0,
198 however, events are queued in ScopedEventQueue and their dispatches are delayed until
199 the scoping level goes back to 0 (by the destruction of EventQueueScope) .
200
201 DOMSubtreeModified, DOMNodeInserted, DOMNodeRemoved, DOMNodeRemovedFromD ocument,
202 DOMNodeInsertedIntoDocument, DOMFocusIn, DOMFocusOut, focusin, and focus out are treated as
203 scoped events, and a scope object is instantiated in EditCommand::apply to delay dispatches
204 of the events until the completion of each call of EditCommand::doApply.
205
206 Test: fast/events/mutation/execCommands.html
207
208 * Android.mk: Added ScopedEventQueue.cpp.
209 * CMakeLists.txt: Ditto.
210 * WebCore.pro: Ditto.
211 * GNUmakefile.am: Added ScopedEventQueue.cpp and ScopedEventQueue.h.
212 * WebCore.gypi: Ditto.
213 * WebCore.vcproj/project.vcproj: Ditto.
214 * WebCore.xcodeproj/project.pbxproj: Ditto.
215 * dom/ContainerNode.cpp:
216 (WebCore::dispatchChildInsertionEvents): Calls dispatchScopedEvent.
217 (WebCore::dispatchChildRemovalEvents): Ditto.
218 * dom/DOMAllInOne.cpp: Added ScopedEventQueue.cpp.
219 * dom/Element.cpp:
220 (WebCore::Element::dispatchAttrRemovalEvent): Ditto.
221 (WebCore::Element::dispatchAttrAdditionEvent): Ditto.
222 * dom/Node.cpp:
223 (WebCore::Node::dispatchScopedEvent): Added.
224 (WebCore::Node::dispatchSubtreeModifiedEvent): Calls dispatchScopedEvent .
225 * dom/Node.h:
226 * dom/ScopedEventQueue.cpp: Added.
227 (WebCore::ScopedEventQueue::initialize): Added.
228 (WebCore::ScopedEventQueue::enqueueEvent): Added.
229 (WebCore::ScopedEventQueue::dispatchAllEvents): Added.
230 (WebCore::ScopedEventQueue::dispatchEvent): Added.
231 (WebCore::ScopedEventQueue::instance): Added.
232 (WebCore::ScopedEventQueue::incrementScopingLevel): Added.
233 (WebCore::ScopedEventQueue::decrementScopingLevel): Added.
234 * dom/ScopedEventQueue.h: Added.
235 (WebCore::ScopedEventQueue::~ScopedEventQueue): Added.
236 (WebCore::ScopedEventQueue::ScopedEventQueue): Added.
237 (WebCore::EventQueueScope::EventQueueScope): Added.
238 (WebCore::EventQueueScope::~EventQueueScope): Added.
239 * editing/EditCommand.cpp:
240 (WebCore::EditCommand::apply): Instantiates EventQueueScope.
241
242 2010-12-09 Sam Weinig <sam@webkit.org>
243
244 Reviewed by Gavin Barraclough.
245
246 Fix scrolling with mouse wheel in WebKit2 views. Once
247 we coalesce wheel events, we can re-enable this.
248
249 * platform/mac/ScrollAnimatorMac.mm:
250 (WebCore::ScrollAnimatorMac::scroll):
251
252 2010-12-09 Abhishek Arya <inferno@chromium.org>
253
254 Reviewed by James Robinson.
255
256 For details element, ensure that if we ended up being inline that we set out replaced
257 flag so that we are treated like an inline block.
258 https://bugs.webkit.org/show_bug.cgi?id=50671
259
260 Test: fast/html/details-element-render-inline-crash.html
261
262 * rendering/RenderDetails.cpp:
263 (WebCore::RenderDetails::styleDidChange): setReplaced to true if we are set as inline.
264 * rendering/RenderDetails.h: function definition.
265
266 2010-12-09 Jasmin Lapalme <jlapalme@druide.com>
267
268 Reviewed by Alexey Proskuryakov.
269
270 Fix a faulty conversion from UTF-8 to UTF-16 in WebCore during an XSLT t ransformation.
271 https://bugs.webkit.org/show_bug.cgi?id=50708
272
273 Test: fast/xsl/utf8-chunks.xml
274
275 * xml/XSLTProcessorLibxslt.cpp:
276 (WebCore::writeToVector): now converts and returns the correct byte coun t when the end of the chunk is in the middle of a multibyte UTF-8 character.
277
278 2010-12-09 Vincent Scheib <scheib@chromium.org>
279
280 Reviewed by James Robinson.
281
282 Clip update rectangle for Texture::updateSubRect to texture size
283 https://bugs.webkit.org/show_bug.cgi?id=49929
284
285 Test: fast/canvas/canvas-largedraws.html
286
287 * platform/graphics/gpu/Texture.cpp:
288 (WebCore::Texture::updateSubRect):
289
290 2010-12-09 Kenneth Russell <kbr@google.com>
291
292 Unreviewed. Another speculative Gtk build fix after r73669. Add
293 needed derived sources to GNUmakefile.am.
294
295 * GNUmakefile.am:
296
297 2010-12-09 Kenneth Russell <kbr@google.com>
298
299 Unreviewed. Speculative Gtk build fix after
300 https://bugs.webkit.org/show_bug.cgi?id=36512 / r73669. Process
301 all of the WebGL classes' IDL files.
302
303 * CMakeLists.txt:
304
305 2010-12-09 Zhenyao Mo <zmo@google.com>
306
307 Reviewed by Kenneth Russell.
308
309 Expose constructor functions for instanceof checks of WebGL objects
310 https://bugs.webkit.org/show_bug.cgi?id=36512
311
312 Test: fast/canvas/webgl/instanceof-test.html
313
314 * bindings/generic/RuntimeEnabledFeatures.h:
315 (WebCore::RuntimeEnabledFeatures::webGLActiveInfoEnabled):
316 (WebCore::RuntimeEnabledFeatures::webGLBufferEnabled):
317 (WebCore::RuntimeEnabledFeatures::webGLFramebufferEnabled):
318 (WebCore::RuntimeEnabledFeatures::webGLProgramEnabled):
319 (WebCore::RuntimeEnabledFeatures::webGLRenderbufferEnabled):
320 (WebCore::RuntimeEnabledFeatures::webGLShaderEnabled):
321 (WebCore::RuntimeEnabledFeatures::webGLTextureEnabled):
322 (WebCore::RuntimeEnabledFeatures::webGLUniformLocationEnabled):
323 * html/canvas/WebGLActiveInfo.idl: Remove OmitConstructor.
324 * html/canvas/WebGLBuffer.idl: Ditto.
325 * html/canvas/WebGLFramebuffer.idl: Ditto.
326 * html/canvas/WebGLProgram.idl: Ditto.
327 * html/canvas/WebGLRenderbuffer.idl: Ditto.
328 * html/canvas/WebGLShader.idl: Ditto.
329 * html/canvas/WebGLTexture.idl: Ditto.
330 * html/canvas/WebGLUniformLocation.idl: Ditto.
331 * page/DOMWindow.idl: Expose constructors for WebGL objects in DOMWindow .
332
333 2010-12-09 Timothy Hatcher <timothy@apple.com>
334
335 Export Color::white and Color::transparent.
336
337 Reviewed by Anders Carlsson.
338
339 * WebCore.exp.in:
340
341 2010-12-09 Sam Weinig <sam@webkit.org>
342
343 Fix failing Mac tests.
344
345 * platform/mac/ScrollAnimatorMac.mm:
346 (WebCore::ScrollAnimatorMac::scroll): Don't smooth scroll if the default
347 AppleScrollAnimationEnabled is false.
348
349 2010-12-09 James Robinson <jamesr@chromium.org>
350
351 Reviewed by Kenneth Russell.
352
353 [chromium] Compositor needs to manage its VRAM use
354 https://bugs.webkit.org/show_bug.cgi?id=49629
355
356 This adds a basic texture manager to the Chromium compositor to limit th e amount of VRAM
357 used by compositor textures and switches ContentLayerChromium, ImageLaye rChromium, and
358 RenderSurfaceChromium to use managed LayerTexture. The other *LayerChro mium classes (Canvas,
359 Video, and WebGL) and the root layer are still unmanaged.
360
361 The TextureManager works by providing tokens to callers that want to use a managed texture.
362 The token can be used to request a texture, see if the previously reques ted texture is still
363 available, and to protect/unprotect textures when they cannot be collect ed. Whenever a
364 texture is created the manager attempts to free up the least recently us ed textures until the
365 total memory use is below the provided threshhold. If the manager canno t satisfy the memory
366 limit it will not return any new textures until some old textures are re leased.
367
368 A LayerTexture wraps a TextureManager token, size, and format. A LayerC hromium can check if a
369 previously requested texture is still available for use and reserve the LayerTexture's underlying
370 storage between the updateContentsIfDirty() and the draw() call.
371
372 Also changes LayerChromium from having separate contentsDirty()/updateCo ntents() calls to a single
373 updateContentsIfDirty().
374
375 Tests: platform/chromium/compositing/lots-of-img-layers-with-opacity.htm l
376 platform/chromium/compositing/lots-of-img-layers.html
377
378 * WebCore.gypi:
379 * platform/graphics/chromium/Canvas2DLayerChromium.cpp:
380 (WebCore::Canvas2DLayerChromium::updateContentsIfDirty):
381 * platform/graphics/chromium/Canvas2DLayerChromium.h:
382 * platform/graphics/chromium/ContentLayerChromium.cpp:
383 (WebCore::ContentLayerChromium::cleanupResources):
384 (WebCore::ContentLayerChromium::updateContentsIfDirty):
385 (WebCore::ContentLayerChromium::updateTextureRect):
386 (WebCore::ContentLayerChromium::draw):
387 * platform/graphics/chromium/ContentLayerChromium.h:
388 * platform/graphics/chromium/ImageLayerChromium.cpp:
389 (WebCore::ImageLayerChromium::updateContentsIfDirty):
390 * platform/graphics/chromium/ImageLayerChromium.h:
391 * platform/graphics/chromium/LayerChromium.h:
392 (WebCore::LayerChromium::updateContentsIfDirty):
393 (WebCore::LayerChromium::draw):
394 * platform/graphics/chromium/LayerRendererChromium.cpp:
395 (WebCore::LayerRendererChromium::LayerRendererChromium):
396 (WebCore::LayerRendererChromium::useShader):
397 (WebCore::LayerRendererChromium::prepareToDrawLayers):
398 (WebCore::LayerRendererChromium::updateRootLayerTextureRect):
399 (WebCore::LayerRendererChromium::drawLayers):
400 (WebCore::LayerRendererChromium::getFramebufferPixels):
401 (WebCore::LayerRendererChromium::createLayerTexture):
402 (WebCore::LayerRendererChromium::deleteLayerTexture):
403 (WebCore::LayerRendererChromium::updateLayersRecursive):
404 (WebCore::LayerRendererChromium::useRenderSurface):
405 (WebCore::LayerRendererChromium::drawLayer):
406 (WebCore::LayerRendererChromium::setScissorToRect):
407 (WebCore::LayerRendererChromium::setDrawViewportRect):
408 (WebCore::LayerRendererChromium::initializeSharedObjects):
409 (WebCore::LayerRendererChromium::cleanupSharedObjects):
410 * platform/graphics/chromium/LayerRendererChromium.h:
411 (WebCore::LayerRendererChromium::renderSurfaceSharedValues):
412 (WebCore::LayerRendererChromium::textureManager):
413 * platform/graphics/chromium/LayerTexture.cpp: Added.
414 (WebCore::LayerTexture::LayerTexture):
415 (WebCore::LayerTexture::~LayerTexture):
416 (WebCore::LayerTexture::isValid):
417 (WebCore::LayerTexture::reserve):
418 (WebCore::LayerTexture::unreserve):
419 (WebCore::LayerTexture::bindTexture):
420 (WebCore::LayerTexture::framebufferTexture2D):
421 * platform/graphics/chromium/LayerTexture.h: Added.
422 (WebCore::LayerTexture::create):
423 * platform/graphics/chromium/PluginLayerChromium.cpp:
424 (WebCore::PluginLayerChromium::updateContentsIfDirty):
425 * platform/graphics/chromium/PluginLayerChromium.h:
426 * platform/graphics/chromium/RenderSurfaceChromium.cpp:
427 (WebCore::RenderSurfaceChromium::SharedValues::SharedValues):
428 (WebCore::RenderSurfaceChromium::SharedValues::~SharedValues):
429 (WebCore::RenderSurfaceChromium::RenderSurfaceChromium):
430 (WebCore::RenderSurfaceChromium::cleanupResources):
431 (WebCore::RenderSurfaceChromium::prepareContentsTexture):
432 (WebCore::RenderSurfaceChromium::draw):
433 * platform/graphics/chromium/RenderSurfaceChromium.h:
434 (WebCore::RenderSurfaceChromium::SharedValues::shaderProgram):
435 (WebCore::RenderSurfaceChromium::SharedValues::shaderSamplerLocation):
436 (WebCore::RenderSurfaceChromium::SharedValues::shaderMatrixLocation):
437 (WebCore::RenderSurfaceChromium::SharedValues::shaderAlphaLocation):
438 (WebCore::RenderSurfaceChromium::SharedValues::initialized):
439 * platform/graphics/chromium/TextureManager.cpp: Added.
440 (WebCore::memoryUseBytes):
441 (WebCore::TextureManager::TextureManager):
442 (WebCore::TextureManager::getToken):
443 (WebCore::TextureManager::releaseToken):
444 (WebCore::TextureManager::hasTexture):
445 (WebCore::TextureManager::protectTexture):
446 (WebCore::TextureManager::unprotectTexture):
447 (WebCore::TextureManager::reduceMemoryToLimit):
448 (WebCore::TextureManager::addTexture):
449 (WebCore::TextureManager::removeTexture):
450 (WebCore::TextureManager::requestTexture):
451 * platform/graphics/chromium/TextureManager.h: Added.
452 (WebCore::TextureManager::create):
453 * platform/graphics/chromium/VideoLayerChromium.cpp:
454 (WebCore::VideoLayerChromium::updateContentsIfDirty):
455 * platform/graphics/chromium/VideoLayerChromium.h:
456 * platform/graphics/chromium/WebGLLayerChromium.cpp:
457 (WebCore::WebGLLayerChromium::updateContentsIfDirty):
458 * platform/graphics/chromium/WebGLLayerChromium.h:
459
460 2010-12-09 Darin Adler <darin@apple.com>
461
462 Reviewed by Sam Weinig.
463
464 Rework my recent setLocation refactoring to use DOMWindow instead of Fra me.
465 It's difficult to make correct security decisions based on Frame since a
466 Frame can navigate to a new document.
467
468 Fixes some test failures that I somehow missed before the last check-in.
469
470 * bindings/js/JSDOMWindowBase.cpp:
471 (WebCore::JSDOMWindowBase::crossDomainAccessErrorMessage): Call to the
472 shell DOMWindow; not sure this one matters, but it's closer to the old
473 code before my last patch. Also pass the DOMWindow rather than the
474 frame to crossDomainAccessErrorMessage.
475
476 * bindings/js/JSDOMWindowCustom.cpp:
477 (WebCore::JSDOMWindow::setLocation): Pass DOMWindow rather than Frame
478 to the DOMWindow::setLocation function.
479
480 * page/DOMWindow.cpp:
481 (WebCore::DOMWindow::setLocation): Take DOMWindow rather than Frame.
482 (WebCore::DOMWindow::crossDomainAccessErrorMessage): Ditto.
483
484 * page/DOMWindow.h: Update new functions to take DOMWindow rather
485 than Frame.
486
487 2010-12-09 Sam Weinig <sam@webkit.org>
488
489 Try and fix the mac build.
490
491 * WebCore.exp.in:
492
493 2010-12-09 Dan Bernstein <mitz@apple.com>
494
495 Reviewed by Dave Hyatt.
496
497 Removed an unused variable.
498
499 * rendering/InlineFlowBox.cpp:
500 (WebCore::InlineFlowBox::computeLogicalBoxHeights): Removed parentLineHe ight.
501
502 2010-12-09 Darin Adler <darin@apple.com>
503
504 Reviewed by Geoffrey Garen.
505
506 Move DOMWindow::setLocation logic into DOMWindow class and out of JavaSc ript binding
507 https://bugs.webkit.org/show_bug.cgi?id=50640
508
509 * bindings/js/JSDOMBinding.cpp:
510 (WebCore::printErrorMessageForFrame): Removed body; just call through to
511 DOMWindow::printErrorMessage.
512
513 * bindings/js/JSDOMWindowBase.cpp:
514 (WebCore::JSDOMWindowBase::crossDomainAccessErrorMessage): Removed body;
515 just call through to DOMWindow::crossDomainAccessErrorMessage.
516
517 * bindings/js/JSDOMWindowCustom.cpp:
518 (WebCore::JSDOMWindow::setLocation): Changed terminology to use activeFr ame and
519 firstFrame, rather than the older lexicalFrame and dynamicFrame. Removed most
520 of the body and moved it into DOMWindow::setLocation.
521
522 * page/DOMWindow.cpp:
523 (WebCore::DOMWindow::setLocation): Added. Does all the same work that
524 JSDOMWindow::setLocation used to do, but in a way that's not specific
525 to JavaScript.
526 (WebCore::DOMWindow::printErrorMessage): Added.
527 (WebCore::DOMWindow::crossDomainAccessErrorMessage): Added.
528
529 * page/DOMWindow.h: Added setLocation, printErrorMessage, and
530 crossDomainAccessErrorMessage.
531
532 2010-12-09 Sam Weinig <sam@webkit.org>
533
534 Reviewed by Dan Bernstein.
535
536 WebKit2 needs smooth scrolling support on the mac
537 <rdar://problem/8219402>
538
539 * WebCore.xcodeproj/project.pbxproj: Change ScrollAnimatorMac.cpp to Scr ollAnimatorMac.mm.
540 * platform/mac/ScrollAnimatorMac.cpp: Removed.
541 * platform/mac/ScrollAnimatorMac.h:
542 * platform/mac/ScrollAnimatorMac.mm: Copied from platform/mac/ScrollAnim atorMac.cpp.
543 (-[ScrollAnimationHelperDelegate initWithScrollAnimator:WebCore::]):
544 (-[ScrollAnimationHelperDelegate bounds]):
545 (-[ScrollAnimationHelperDelegate _immediateScrollToPoint:]):
546 (-[ScrollAnimationHelperDelegate convertSizeToBase:]):
547 (-[ScrollAnimationHelperDelegate convertSizeFromBase:]):
548 (-[ScrollAnimationHelperDelegate superview]):
549 (-[ScrollAnimationHelperDelegate documentView]):
550 (-[ScrollAnimationHelperDelegate window]):
551 (-[ScrollAnimationHelperDelegate _recursiveRecomputeToolTips]):
552 (WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
553 (WebCore::ScrollAnimatorMac::scroll):
554 (WebCore::ScrollAnimatorMac::setScrollPositionAndStopAnimation):
555 (WebCore::ScrollAnimatorMac::currentPosition):
556 (WebCore::ScrollAnimatorMac::immediateScrollToPoint):
557 Add implementation of ScrollAnimator for the Mac.
558
559 2010-12-09 Brady Eidson <beidson@apple.com>
560
561 Reviewed by Anders Carlsson.
562
563 <rdar://problem/8613779> and https://bugs.webkit.org/show_bug.cgi?id=507 77
564 WebKit2 ContextMenuClient support
565
566 Export some symbols and headers needed by WebKit2 Mac:
567 * WebCore.exp.in:
568 * WebCore.xcodeproj/project.pbxproj:
569
570 2010-12-09 Sheriff Bot <webkit.review.bot@gmail.com>
571
572 Unreviewed, rolling out r73635.
573 http://trac.webkit.org/changeset/73635
574 https://bugs.webkit.org/show_bug.cgi?id=50778
575
576 'Side-effects on 3 css tests needs closer review' (Requested
577 by mwenge on #webkit).
578
579 * platform/graphics/qt/ImageQt.cpp:
580 (loadResourcePixmap):
581 * platform/qt/RenderThemeQt.cpp:
582 (WebCore::RenderThemeQt::computeSizeBasedOnStyle):
583 (WebCore::RenderThemeQt::paintSearchField):
584 (WebCore::RenderThemeQt::adjustSearchFieldStyle):
585 (WebCore::RenderThemeQt::adjustSearchFieldCancelButtonStyle):
586 (WebCore::RenderThemeQt::paintSearchFieldCancelButton):
587 * platform/qt/RenderThemeQt.h:
588
589 2010-12-09 Robert Hogan <robert@webkit.org>
590
591 Reviewed by Andreas Kling.
592
593 [Qt] Search input field doesn't have cancel button
594
595 Add a cancel button to the search field and make it customizable
596 by the client. For now, use the close dialog button associated
597 with the application's style as the default.
598
599 https://bugs.webkit.org/show_bug.cgi?id=42887
600
601 * platform/graphics/qt/ImageQt.cpp:
602 (loadResourcePixmap):
603 * platform/qt/RenderThemeQt.cpp:
604 (WebCore::RenderThemeQt::computeSizeBasedOnStyle):
605 (WebCore::RenderThemeQt::paintSearchField):
606 (WebCore::RenderThemeQt::adjustSearchFieldStyle):
607 (WebCore::RenderThemeQt::adjustSearchFieldCancelButtonStyle):
608 (WebCore::RenderThemeQt::convertToPaintingRect):
609 (WebCore::RenderThemeQt::paintSearchFieldCancelButton):
610 * platform/qt/RenderThemeQt.h:
611
612 2010-12-09 Yael Aharon <yael.aharon@nokia.com>
613
614 Reviewed by Antonio Gomes.
615
616 Spatial Navigation: Crash when handling iframe of size 0.
617 https://bugs.webkit.org/show_bug.cgi?id=50730
618
619 if we have a frame of size 0, we would get into infinite loop and eventu ally crash. The reason is
620 that when the algorithm sees a starting rect of size 0, it assumes that there is no focused node,
621 thus restarts itself. The solution is to avoid considering iframes with size 0 for the spatial
622 navigation algorithm.
623
624 Test: fast/spatial-navigation/snav-hidden-iframe-zero-size.html
625
626 * page/FocusController.cpp:
627 (WebCore::updateFocusCandidateIfNeeded):
628
629 2010-12-09 Sheriff Bot <webkit.review.bot@gmail.com>
630
631 Unreviewed, rolling out r73616.
632 http://trac.webkit.org/changeset/73616
633 https://bugs.webkit.org/show_bug.cgi?id=50772
634
635 Breaks chromium win build (Requested by hwennborg on #webkit).
636
637 * bindings/v8/IDBBindingUtilities.cpp:
638 (WebCore::createIDBKeyFromValue):
639 * bindings/v8/custom/V8IDBKeyCustom.cpp:
640 (WebCore::toV8):
641 * storage/IDBFactoryBackendImpl.cpp:
642 (WebCore::createTables):
643 (WebCore::IDBFactoryBackendImpl::open):
644 * storage/IDBKey.cpp:
645 (WebCore::IDBKey::IDBKey):
646 (WebCore::IDBKey::fromQuery):
647 (WebCore::IDBKey::bind):
648 (WebCore::IDBKey::bindWithNulls):
649 * storage/IDBKey.h:
650 (WebCore::IDBKey::create):
651 (WebCore::IDBKey::number):
652
653 2010-12-09 Antonio Gomes <agomes@rim.com>
654
655 Rubber stamped by by Gustavo Noronha Silva.
656
657 Buildfix for GTK+ with building with -no-video.
658
659 paintStockIcon static function was implemented under the ENABLE(VIDEO) g uard
660 but used from outside the guard. See RenderThemeGtk::paintSearchFieldRes ultsDecoration()
661 and RenderThemeGtk::paintSearchFieldCancelButton() methods.
662
663 * platform/gtk/RenderThemeGtk.cpp:
664 (WebCore::getMediaElementFromRenderObject):
665
666 2010-12-07 Antonio Gomes <agomes@rim.com>
667
668 Reviewed by Daniel Bates.
669
670 Spatial Navigation: code clean up
671 https://bugs.webkit.org/show_bug.cgi?id=50666
672
673 Patch unifies two FocusCandidate constructors, making caller sites
674 simpler. Now the special handling HTMLAreaElement gets is done within
675 the non default constructor (i.e. FocusCanditate(Node*, FocusDirection)) .
676
677 No new tests needed.
678
679 * page/FocusController.cpp:
680 (WebCore::FocusController::findFocusCandidateInContainer):
681 * page/SpatialNavigation.cpp:
682 (WebCore::FocusCandidate::FocusCandidate):
683
684 2010-12-09 Philippe Normand <pnormand@igalia.com>
685
686 Reviewed by Eric Carlson.
687
688 [GStreamer] disable fullscreen on MacOS Tiger and Leopard
689 https://bugs.webkit.org/show_bug.cgi?id=50748
690
691 Don't support fullscreen video on Tiger and Leopard, just like the
692 QTKit player.
693
694 * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
695 (WebCore::MediaPlayerPrivateGStreamer::supportsFullscreen):
696
697 2010-12-06 Philippe Normand <pnormand@igalia.com>
698
699 Reviewed by Martin Robinson.
700
701 [GTK] Support the Mozilla-style Fullscreen Javascript API
702 https://bugs.webkit.org/show_bug.cgi?id=50572
703
704 * GNUmakefile.am: enable the Javascript Fullscreen API feature if
705 it's been requested at configure time.
706
707 2010-12-09 Yong Li <yoli@rim.com>
708
709 Reviewed by Darin Adler.
710
711 Check the return value of ImageBuffer::create()
712 to avoid crash when ImageBuffer::create() fails.
713 https://bugs.webkit.org/show_bug.cgi?id=50631
714
715 No new test because it relies on the platform implementation
716 of ImageBuffer. It is hard to make ImageBuffer::create() fail
717 in most ports.
718
719 * platform/graphics/GeneratedImage.cpp:
720 (WebCore::GeneratedImage::drawPattern):
721
722 2010-12-09 Maciej Stachowiak <mjs@apple.com>
723
724 Reviewed by Dan Bernstein.
725
726 Implement "Use Selection for Find" in WebKit2
727 https://bugs.webkit.org/show_bug.cgi?id=50737
728 <rdar://problem/8564881>
729
730 Implement a TakeFindStringFromSelection editor command. This is
731 used solely to implement the "Use Selection for Find" menu command
732 on Mac, and is not made available to script. On WebKit2, it is
733 very convenient to reuse the editing machinery since this command
734 is very similar to Copy.
735
736 * editing/Editor.h:
737 * editing/EditorCommand.cpp:
738 (WebCore::executeTakeFindStringFromSelection): Call to a mac-only Editor function.
739 (WebCore::enabledTakeFindStringFromSelection): Check using Editor::canCo pyExcludingStandaloneImage
740 (WebCore::createCommandMap): Add "TakeFindStringFromSelection" command.
741 * editing/mac/EditorMac.mm:
742 (WebCore::Editor::canCopyExcludingStandaloneImages): Helper function; we can't use Editor::canCopy
743 since it would make no sense to enable "Use Selection for Find" when vie wing a standalone image
744 document.
745 (WebCore::Editor::takeFindStringFromSelection): Implement by copying the selected text
746 to the special Find pasteboard.
747
748 2010-12-09 Abhishek Arya <inferno@chromium.org>
749
750 Reviewed by Dimitri Glazkov.
751
752 As part of r73559, I added the referenceNode check to validate whether t he root
753 node of the iterator matches the node which is getting moved to other do cument.
754 referenceNode is initialized to root, however can get moved using previo usNode
755 and nextNode methods, so it is required to use root directly.
756 https://bugs.webkit.org/show_bug.cgi?id=50764
757
758 Test: fast/dom/node-iterator-reference-node-moved-crash.html
759
760 * dom/Document.cpp:
761 (WebCore::Document::moveNodeIteratorsToNewDocument): change referenceNod e to root.
762
763 2010-12-08 Dimitri Glazkov <dglazkov@chromium.org>
764
765 Reviewed by Darin Adler.
766
767 Provide a generic way to store shadowParent on a Node.
768 https://bugs.webkit.org/show_bug.cgi?id=50184
769
770 This patch makes TreeShared::m_parent act as either parentNode() or
771 shadowHost() for Node. The distinction is controlled by IsShadowRootFlag .
772
773 Refactoring, so no new tests. See performance result testing in bug.
774
775 * dom/Element.cpp:
776 (WebCore::Element::recalcStyle): Changed to use parentOrHostNode().
777 * dom/Node.cpp:
778 (WebCore::Node::shadowHost): Added.
779 (WebCore::Node::setShadowHost): Added.
780 (WebCore::Node::isContentEditable): Changed to use parentOrHostNode().
781 (WebCore::Node::isContentRichlyEditable): Ditto.
782 (WebCore::Node::nextRenderer): Ditto.
783 (WebCore::Node::virtualComputedStyle): Ditto.
784 (WebCore::Node::canStartSelection): Ditto.
785 (WebCore::Node::shadowTreeRootNode): Changed to use parentNodeGuaranteed HostFree().
786 (WebCore::Node::getEventAncestors): Ditto.
787 (WebCore::Node::defaultEventHandler): Changed to use parentOrHostNode().
788 * dom/Node.h: Added an extra flag and adjusted bit counts.
789 (WebCore::Node::isShadowNode): Made non-virtual, switched to use flag.
790 (WebCore::Node::parentNode): Made to recognize flag.
791 (WebCore::Node::parentOrHostNode): Changed to use straight parent() and made const.
792 (WebCore::Node::parentNodeGuaranteedHostFree): Added.
793 (WebCore::Node::shadowParentNode): Made non-virtual and const.
794 * editing/TextIterator.cpp:
795 (WebCore::depthCrossingShadowBoundaries): Changed to use parentOrHostNod e();
796 (WebCore::nextInPreOrderCrossingShadowBoundaries): Ditto.
797 (WebCore::previousInPostOrderCrossingShadowBoundaries): Ditto.
798 (WebCore::setUpFullyClippedStack): Ditto.
799 (WebCore::TextIterator::advance): Ditto.
800 (WebCore::SimplifiedBackwardsTextIterator::advance): Ditto.
801 * page/DOMSelection.cpp:
802 (WebCore::DOMSelection::anchorNode): Changed to use parentNodeGuaranteed HostFree().
803 (WebCore::DOMSelection::focusNode): Ditto.
804 (WebCore::DOMSelection::baseNode): Ditto.
805 (WebCore::DOMSelection::extentNode): Ditto.
806 (WebCore::DOMSelection::getRangeAt): Ditto.
807 * rendering/MediaControlElements.cpp:
808 (WebCore::MediaControlShadowRootElement::MediaControlShadowRootElement):
809 Changed to setShadowHost().
810 (WebCore::MediaControlShadowRootElement::updateStyle): Changed to use sh adowHost().
811 (WebCore::MediaControlShadowRootElement::detach): Added an override to
812 explicitly set shadowHost to 0. Otherwise, the element will leak.
813 * rendering/MediaControlElements.h: Added detach def, removed members th at are
814 no longer needed.
815 * rendering/RenderSVGShadowTreeRootContainer.cpp:
816 (WebCore::RenderSVGShadowTreeRootContainer::~RenderSVGShadowTreeRootCont ainer):
817 Added explicit clearing of shadowHost to avoid leaking and crashes,
818 because SVG shadow DOM can be dynamically attached/detached, produci ng
819 stale nodes in over/out event handling.
820 * rendering/RenderSlider.cpp:
821 (WebCore::SliderThumbElement::defaultEventHandler): Changed to use shado wHost().
822 * rendering/RenderTextControlSingleLine.cpp:
823 (WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine):
824 Added explicit clearing of shadowHost and explicit destruction to
825 avoid out-of-order removal of children.
826 * rendering/RenderTreeAsText.cpp:
827 (WebCore::nodePosition): Simplified code.
828 * rendering/SVGShadowTreeElements.cpp:
829 (WebCore::SVGShadowTreeRootElement::SVGShadowTreeRootElement): Added
830 setting of shadowHost.
831 (WebCore::SVGShadowTreeRootElement::attachElement): Changed to use shado wHost().
832 (WebCore::SVGShadowTreeRootElement::clearShadowHost): Added.
833 * rendering/SVGShadowTreeElements.h: Added def, removed members that are
834 no longer needed.
835 * rendering/ShadowElement.cpp:
836 (WebCore::ShadowBlockElement::initAsPart): Changed to use shadowHost().
837 * rendering/ShadowElement.h: Removed members that are no longer needed.
838 (WebCore::ShadowElement::ShadowElement): Added setting of shadowHost.
839 (WebCore::ShadowElement::detach): Added.
840 * rendering/TextControlInnerElements.cpp:
841 (WebCore::TextControlInnerElement::TextControlInnerElement): Added setti ng
842 of shadowHost.
843 (WebCore::TextControlInnerElement::attachInnerElement): Changed to use
844 isShadowNode().
845 (WebCore::TextControlInnerElement::detach): Added.
846 * rendering/TextControlInnerElements.h: Removed members that are no
847 longer needed.
848 * svg/SVGElement.cpp:
849 (WebCore::SVGElement::ownerSVGElement): Simplified code.
850 (WebCore::SVGElement::viewportElement): Ditto.
851 * svg/SVGLocatable.cpp:
852 (WebCore::SVGLocatable::computeCTM): Ditto.
853 * svg/SVGStyledElement.cpp:
854 (WebCore::SVGStyledElement::title): Ditto.
855 * svg/SVGUseElement.cpp:
856 (WebCore::ShadowTreeUpdateBlocker::while): Ditto.
857
858 2010-12-09 Brady Eidson <beidson@apple.com>
859
860 Reviewed by Maciej Stachowiak.
861
862 <rdar://problem/7660733> and https://bugs.webkit.org/show_bug.cgi?id=501 91
863 WebKit2 Authentication Support
864
865 * WebCore.exp.in:
866
867 2010-12-09 Peter Beverloo <peter@lvp-media.com>
868
869 Reviewed by Maciej Stachowiak.
870
871 Default CSS definitions for the figure and figcaption elements.
872
873 Tests: fast/html/figcaption-element.html
874 fast/html/figure-element.html
875
876 * css/html.css:
877 (figure): The default figure-style equals a blockquote
878 (figcaption): A non-sectioning block-level element
879
880 2010-12-09 Yury Semikhatsky <yurys@chromium.org>
881
882 Reviewed by Pavel Feldman.
883
884 Web Inspector: Console records for failed XHRs should contain call stack and request method
885 https://bugs.webkit.org/show_bug.cgi?id=50390
886
887 When inspector front-end is open we capture call stack at the place wher e request is sent and
888 pass the stack along with other request data. There is a new type of con sole messages which
889 is NetworkErrorMessageType, all messages of that type will have requestI d field initialized
890 with the corresponding network request identifier so that later on when we need to display
891 that message in the front-end we could pull request data from the Networ k panel using
892 this identifier. If there are no data for given requestId message format ting falls back to
893 the old implementation which lacks such things as call stack, request me thod and exact
894 source location.
895
896 * inspector/ConsoleMessage.cpp:
897 (WebCore::ConsoleMessage::ConsoleMessage):
898 (WebCore::ConsoleMessage::addToFrontend):
899 (WebCore::ConsoleMessage::isEqual):
900 * inspector/ConsoleMessage.h:
901 * inspector/Inspector.idl:
902 * inspector/InspectorController.cpp:
903 (WebCore::InspectorController::didReceiveResponse):
904 (WebCore::InspectorController::didFailLoading):
905 * inspector/InspectorResourceAgent.cpp:
906 (WebCore::InspectorResourceAgent::identifierForInitialRequest):
907 * inspector/front-end/ConsoleView.js:
908 (WebInspector.ConsoleView.prototype.updateMessageRepeatCount):
909 (WebInspector.ConsoleMessage):
910 (WebInspector.ConsoleMessage.prototype._formatMessage):
911 (WebInspector.ConsoleMessage.prototype.toMessageElement):
912 (WebInspector.ConsoleMessage.prototype.toString):
913 (WebInspector.ConsoleMessage.prototype.isEqual):
914 * inspector/front-end/ResourceManager.js:
915 (WebInspector.ResourceManager.prototype.identifierForInitialRequest):
916 * inspector/front-end/inspector.js:
917 (WebInspector.addConsoleMessage):
918 * page/Console.h:
919
920 2010-12-09 Dai Mikurube <dmikurube@google.com>
921
922 Reviewed by Kent Tamura.
923
924 Implement "required" attribute for select tags
925 https://bugs.webkit.org/show_bug.cgi?id=50380
926
927 Test: fast/forms/select-live-pseudo-selectors.html
928 platform/mac/fast/objc/dom-html-select-live-pseudo-selectors.html
929
930 * dom/SelectElement.cpp:
931 (WebCore::SelectElement::updateValidity): Added. It's a pure virtual fun ction which is prepared so that HTMLSelectElement::updateValidity() calls HTMLSe lectElement::setNeedsValidityCheck().
932 (WebCore::SelectElement::parseMultipleAttribute): Added calling updateVa lidity().
933 * html/HTMLSelectElement.cpp:
934 (WebCore::HTMLSelectElement::deselectItems): Added calling setNeedsValid ityCheck() to enable validity check after changing. No tests for this change sin ce this function is not exposed to JavaScript or any web interface.
935 (WebCore::HTMLSelectElement::setSelectedIndex): Added calling setNeedsVa lidityCheck().
936 (WebCore::HTMLSelectElement::setSelectedIndexByUser): Added calling setN eedsValidityCheck().
937 (WebCore::HTMLSelectElement::valueMissing): Added valueMissing() to chec k if selecting an invalid or placeholder label option when a valid required attr ibute is specified.
938 (WebCore::HTMLSelectElement::listBoxSelectItem): Added calling setNeedsV alidityCheck(). No tests for this change since it is not called yet. Look at the bug 36177 and the changeset 56180.
939 (WebCore::HTMLSelectElement::add): Added calling setNeedsValidityCheck() .
940 (WebCore::HTMLSelectElement::remove): Added calling setNeedsValidityChec k().
941 (WebCore::HTMLSelectElement::restoreFormControlState): Added calling set NeedsValidityCheck().
942 (WebCore::HTMLSelectElement::parseMappedAttribute): Added calling setNee dsValidityCheck().
943 (WebCore::HTMLSelectElement::selectAll): Added calling setNeedsValidityC heck().
944 (WebCore::HTMLSelectElement::reset): Added calling setNeedsValidityCheck ().
945 (WebCore::HTMLSelectElement::updateListBoxSelection): Added calling setN eedsValidityCheck(). Skipped adding tests for this change as too complicated..
946 (WebCore::HTMLSelectElement::setLength): Added calling setNeedsValidityC heck().
947 (WebCore::HTMLSelectElement::isRequiredFormControl): Check if required o r not.
948 (WebCore::HTMLSelectElement::hasPlaceholderLabelOption): Added.
949 (WebCore::HTMLSelectElement::updateValidity): Added. It calls setNeedsVa lidityCheck().
950 * html/HTMLSelectElement.h:
951 (WebCore::HTMLSelectElement::isOptionalFormControl): Check if not requir ed.
952 * html/HTMLSelectElement.idl: Added a required attribute to select eleme nts..
953 * html/ValidityState.cpp:
954 (WebCore::ValidityState::valueMissing): Added valueMissing check for sel ect elements into the global checker, ValidityState::valueMissing().
955 * wml/WMLSelectElement.h:
956 (WebCore::WMLSelectElement::updateValidity): Added. It does nothing.
957
958 2010-12-07 Jeremy Orlow <jorlow@chromium.org>
959
960 Reviewed by Steve Block.
961
962 IndexedDB returns the wrong exceptions
963 https://bugs.webkit.org/show_bug.cgi?id=50632
964
965 IndexedDB exceptions need to have an offset so they can
966 be distinguished from DOM exceptions. We also need to
967 add strings for the various exceptions. Lastly, make
968 IDBDatabaseException use the common exception base class.
969
970 * bindings/js/JSDOMBinding.cpp:
971 (WebCore::setDOMException):
972 * bindings/v8/V8Proxy.cpp:
973 (WebCore::V8Proxy::setDOMException):
974 * dom/ExceptionCode.cpp:
975 (WebCore::getExceptionCodeDescription):
976 * dom/ExceptionCode.h:
977 * storage/IDBDatabaseError.h:
978 (WebCore::IDBDatabaseError::code):
979 * storage/IDBDatabaseException.h:
980 (WebCore::IDBDatabaseException::create):
981 (WebCore::IDBDatabaseException::ErrorCodeToExceptionCode):
982 (WebCore::IDBDatabaseException::IDBDatabaseException):
983 * storage/IDBDatabaseException.idl:
984
985 2010-12-09 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
986
987 Build fix for GTK+3. Use functions added for GTK+ 2.24 to get the
988 GDK window size.
989
990 * plugins/gtk/gtk2xtbin.c:
991 (gtk_xtbin_realize):
992
993 2010-12-09 Siddharth Mathur <siddharth.mathur@nokia.com>
994
995 Reviewed by Laszlo Gombos.
996
997 Use BUILDING_WEBKIT like other ports
998 https://bugs.webkit.org/show_bug.cgi?id=50713
999
1000 * WebCore.pro: Change BUILD_WEBKIT to BUILDING_WEBKIT
1001
1002 2010-12-08 Erik Arvidsson <arv@chromium.org>
1003
1004 Reviewed by Darin Adler.
1005
1006 Replace getAttribute().isNull() with fastHasAttribute()
1007 https://bugs.webkit.org/show_bug.cgi?id=50719
1008
1009 Covered by existing tests.
1010
1011 * dom/SelectElement.cpp:
1012 (WebCore::SelectElement::reset):
1013 * html/HTMLAppletElement.cpp:
1014 (WebCore::HTMLAppletElement::rendererIsNeeded):
1015 * html/HTMLCollection.cpp:
1016 (WebCore::HTMLCollection::itemAfter):
1017 * html/HTMLFormControlElement.cpp:
1018 (WebCore::HTMLFormControlElement::formNoValidate):
1019 * html/HTMLFormElement.cpp:
1020 (WebCore::HTMLFormElement::noValidate):
1021 * html/HTMLInputElement.cpp:
1022 (WebCore::HTMLInputElement::defaultChecked):
1023 (WebCore::HTMLInputElement::multiple):
1024 (WebCore::HTMLInputElement::webkitdirectory):
1025 * html/HTMLOptionElement.cpp:
1026 (WebCore::HTMLOptionElement::defaultSelected):
1027 * html/HTMLScriptElement.cpp:
1028 (WebCore::HTMLScriptElement::asyncAttributeValue):
1029 (WebCore::HTMLScriptElement::deferAttributeValue):
1030 * rendering/RenderFileUploadControl.cpp:
1031 (WebCore::RenderFileUploadControl::allowsMultipleFiles):
1032 (WebCore::RenderFileUploadControl::allowsDirectoryUpload):
1033
1034 2010-12-08 Nicolas Dufresne <nicolas.dufresne@collabora.co.uk>
1035
1036 Reviewed by Martin Robinson.
1037
1038 Full page size flash plugins do not show in all situations
1039 https://bugs.webkit.org/show_bug.cgi?id=47742
1040
1041 This patch moves the plugin widget size allocation after the
1042 NPP_SetWindow is called with the effect that the resize of Flash
1043 content no longer result in grey flash. This seems logical since the
1044 widget tree cannot be fully constructed before the plugin receives
1045 the new container window.
1046
1047 Test: manual-tests/plugins/gtk-windowed-grey-glitch.html
1048
1049 * plugins/gtk/PluginViewGtk.cpp:
1050 (WebCore::PluginView::setNPWindowIfNeeded):
1051
1 2010-12-08 David Hyatt <hyatt@apple.com> 1052 2010-12-08 David Hyatt <hyatt@apple.com>
2 1053
3 Reviewed by Simon Fraser. 1054 Reviewed by Simon Fraser.
4 1055
5 Fix regression from xji's wheel scroll patch. The vertical case is look ing at the horizontal 1056 Fix regression from xji's wheel scroll patch. The vertical case is look ing at the horizontal
6 maximum position and not the vertical position. 1057 maximum position and not the vertical position.
7 1058
8 * platform/ScrollView.cpp: 1059 * platform/ScrollView.cpp:
9 (WebCore::ScrollView::wheelEvent): 1060 (WebCore::ScrollView::wheelEvent):
10 1061
(...skipping 1406 matching lines...) Expand 10 before | Expand all | Expand 10 after
1417 (WebCore::ScriptCallFrame::buildInspectorObject): 2468 (WebCore::ScriptCallFrame::buildInspectorObject):
1418 * inspector/ScriptCallFrame.h: 2469 * inspector/ScriptCallFrame.h:
1419 (WebCore::ScriptCallFrame::sourceURL): 2470 (WebCore::ScriptCallFrame::sourceURL):
1420 * inspector/ScriptCallStack.h: 2471 * inspector/ScriptCallStack.h:
1421 * inspector/TimelineRecordFactory.cpp: 2472 * inspector/TimelineRecordFactory.cpp:
1422 (WebCore::TimelineRecordFactory::createGenericRecord): 2473 (WebCore::TimelineRecordFactory::createGenericRecord):
1423 * inspector/front-end/ConsoleView.js: 2474 * inspector/front-end/ConsoleView.js:
1424 (WebInspector.ConsoleMessage.prototype._populateStackTraceTreeElement): 2475 (WebInspector.ConsoleMessage.prototype._populateStackTraceTreeElement):
1425 2476
1426 == Rolled over to ChangeLog-2010-12-06 == 2477 == Rolled over to ChangeLog-2010-12-06 ==
OLDNEW
« no previous file with comments | « LayoutTests/storage/indexeddb/objectstore-cursor.html ('k') | WebCore/bindings/v8/IDBBindingUtilities.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698