signin: record http response codes and net errors in OAuth2AccessTokenFetcher.

signin: record http response codes and net errors in OAuth2AccessTokenFetcher.

I also changed the token fetcher to return SERVICE_ERROR when
we see an HTTP 400 + custom service error, versus INVALID_GAIA_CREDENTIALS.

R=courage@chromium.org, droger@chromium.org, pavely@chromium.org, rlarocque@chromium.org
TBR=rlarocque@chromium.org
(/invalidation)


BUG=314705
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233277

[tim (not reviewing), 2013-11-04 22:31:32]

Pavel, please review.  +David FYI.

[pavely, 2013-11-04 23:25:13]

On 2013/11/04 22:31:32, timsteele wrote:
> Pavel, please review.  +David FYI.

There should be profile_sync_service.cc in the list of changed files. Code
pattern there is similar to ticl_invalidation_service.cc

[pavely, 2013-11-04 23:25:27]

https://codereview.chromium.org/57993006/diff/30001/google_apis/gaia/oauth2_a...
File google_apis/gaia/oauth2_access_token_fetcher.cc (right):

https://codereview.chromium.org/57993006/diff/30001/google_apis/gaia/oauth2_a...
google_apis/gaia/oauth2_access_token_fetcher.cc:188:
GoogleServiceAuthError::SERVICE_ERROR));
You still need to return INVALID_GAIA_CREDENTIALS for invalid_grant

[tim (not reviewing), 2013-11-04 23:51:35]

Thanks Pavel.  Please have another look.

[pavely, 2013-11-04 23:57:46]

On 2013/11/04 23:51:35, timsteele wrote:
> Thanks Pavel.  Please have another look.

lgtm but you'll need to get one from committer.

[droger, 2013-11-05 00:01:24]

lgtm

[tim (not reviewing), 2013-11-05 14:57:34]

+rlarocque for invalidation owners
+courage for identity_api

I'm TBRing the CL because this should have no real effect (previously the code
was handling the code as INVALID_GAIA_CREDENTIALS, now it's SERVICE_ERROR, but
same case).

I'm happy to follow up if needed!

[tim (not reviewing), 2013-11-05 15:12:38]

On 2013/11/05 14:57:34, timsteele wrote:
> +rlarocque for invalidation owners
> +courage for identity_api
> 
> I'm TBRing the CL because this should have no real effect (previously the code
> was handling the code as INVALID_GAIA_CREDENTIALS, now it's SERVICE_ERROR, but
> same case).
> 
> I'm happy to follow up if needed!

Actually, I'll hold off until courage@ reviews this.  I'm not sure if it has any
side effects in identity_api.

[Michael Courage, 2013-11-05 18:51:06]

lgtm

[commit-bot: I haz the power, 2013-11-05 19:24:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tim@chromium.org/57993006/990001

[commit-bot: I haz the power, 2013-11-05 20:22:01]

Retried try job too often on linux_rel for step(s) interactive_ui_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-11-05 21:24:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tim@chromium.org/57993006/990001

[rlarocque, 2013-11-05 22:52:35]

lgtm

[commit-bot: I haz the power, 2013-11-05 23:14:34]

Retried try job too often on linux_rel for step(s) interactive_ui_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-11-06 14:34:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tim@chromium.org/57993006/990001

[tim (not reviewing), 2013-11-06 16:14:51]

Committed patchset #6 manually as r233277 (presubmit successful).