chrome/browser/extensions/api/identity/identity_api.cc - Issue 57993006: signin: record http response codes and net errors in OAuth2AccessTokenFetcher.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/identity/identity_api.cc

Issue 57993006: signin: record http response codes and net errors in OAuth2AccessTokenFetcher. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: eof Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/identity/experimental_identity_api.cc ('k') | chrome/browser/invalidation/ticl_invalidation_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/identity/identity_api.cc

diff --git a/chrome/browser/extensions/api/identity/identity_api.cc b/chrome/browser/extensions/api/identity/identity_api.cc

index fbbdca0c03e32278892dc55309ecfda5c29336b8..1850ab0f96a74ebfa480ac358bf964efd58bfcd1 100644

--- a/chrome/browser/extensions/api/identity/identity_api.cc

+++ b/chrome/browser/extensions/api/identity/identity_api.cc

@@ -283,6 +283,7 @@ void IdentityGetAuthTokenFunction::OnMintTokenFailure(

switch (error.state()) {

case GoogleServiceAuthError::INVALID_GAIA_CREDENTIALS:

+ case GoogleServiceAuthError::SERVICE_ERROR:

case GoogleServiceAuthError::ACCOUNT_DELETED:

case GoogleServiceAuthError::ACCOUNT_DISABLED:

extensions::IdentityAPI::GetFactoryInstance()