Remove content dependency from TransportSecurityPersister.

chrome/browser/net/transport_security_persister.h

Index: chrome/browser/net/transport_security_persister.h
diff --git a/chrome/browser/net/transport_security_persister.h b/chrome/browser/net/transport_security_persister.h
index 644082d4730e5ef44ec8266cd9243f1649adfb63..c2212e73de61ff4adea9a5de5c886d423cc16a7d 100644
--- a/chrome/browser/net/transport_security_persister.h
+++ b/chrome/browser/net/transport_security_persister.h
@@ -37,9 +37,14 @@
 
 #include "base/files/file_path.h"
 #include "base/files/important_file_writer.h"
+#include "base/memory/ref_counted.h"
 #include "base/memory/weak_ptr.h"
 #include "net/http/transport_security_state.h"
 
+namespace base {
+class SequencedTaskRunner;
+}
+
 // Reads and updates on-disk TransportSecurity state.
 // Must be created, used and destroyed only on the IO thread.

[battre, 2013/11/05 11:54:36]

Here you talk about IO thread while this gets somewhat lost in the rest. I think
it would be good to explain the threading of this class w.r.t. the two
SequencedTaskRunners.

[Aaron Boodman, 2013/11/06 21:57:06]

Done.

 class TransportSecurityPersister
@@ -48,6 +53,7 @@ class TransportSecurityPersister
  public:
   TransportSecurityPersister(net::TransportSecurityState* state,
                              const base::FilePath& profile_path,
+                             base::SequencedTaskRunner* file_task_runner,
                              bool readonly);
   virtual ~TransportSecurityPersister();
 
@@ -94,8 +100,6 @@ class TransportSecurityPersister
   bool LoadEntries(const std::string& serialized, bool* dirty);
 
  private:
-  class Loader;
-
   // Populates |state| from the JSON string |serialized|. Returns true if
   // all entries were parsed and deserialized correctly.
   //
@@ -112,6 +116,9 @@ class TransportSecurityPersister
   // Helper for safely writing the data.
   base::ImportantFileWriter writer_;
 
+  scoped_refptr<base::SequencedTaskRunner> foreground_runner_;
+  scoped_refptr<base::SequencedTaskRunner> background_runner_;

[battre, 2013/11/05 11:54:36]

Add comments that foreground is IO thread and background is file thread? Maybe
even rename them accordingly?

[Aaron Boodman, 2013/11/06 21:57:06]

In Mojo, this class isn't necessarily created on the IO thread. I'd rather not
couple the implementation to its usage in Chrome.

+
   // Whether or not we're in read-only mode.
   const bool readonly_;