Remove content dependency from TransportSecurityPersister.

chrome/browser/net/transport_security_persister.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // TransportSecurityState maintains an in memory database containing the
 // list of hosts that currently have transport security enabled. This
 // singleton object deals with writing that data out to disk as needed and
 // loading it at startup.
 
 // At startup we need to load the transport security state from the
@@ skipping 19 matching lines @@
 //   copies the current state of the TransportSecurityState, serializes
 //   and writes to disk.
 
 #ifndef CHROME_BROWSER_NET_TRANSPORT_SECURITY_PERSISTER_H_
 #define CHROME_BROWSER_NET_TRANSPORT_SECURITY_PERSISTER_H_
 
 #include <string>
 
 #include "base/files/file_path.h"
 #include "base/files/important_file_writer.h"
+#include "base/memory/ref_counted.h"
 #include "base/memory/weak_ptr.h"
 #include "net/http/transport_security_state.h"
 
+namespace base {
+class SequencedTaskRunner;
+}
+
 // Reads and updates on-disk TransportSecurity state.
 // Must be created, used and destroyed only on the IO thread.

[battre, 2013/11/05 11:54:36]

Here you talk about IO thread while this gets somewhat lost in the rest. I think
it would be good to explain the threading of this class w.r.t. the two
SequencedTaskRunners.

[Aaron Boodman, 2013/11/06 21:57:06]

Done.

 class TransportSecurityPersister
     : public net::TransportSecurityState::Delegate,
       public base::ImportantFileWriter::DataSerializer {
  public:
   TransportSecurityPersister(net::TransportSecurityState* state,
                              const base::FilePath& profile_path,
+                             base::SequencedTaskRunner* file_task_runner,
                              bool readonly);
   virtual ~TransportSecurityPersister();
 
   // Called by the TransportSecurityState when it changes its state.
   virtual void StateIsDirty(net::TransportSecurityState*) OVERRIDE;
 
   // ImportantFileWriter::DataSerializer:
   //
   // Serializes |transport_security_state_| into |*output|. Returns true if
   // all DomainStates were serialized correctly.
@@ skipping 26 matching lines @@
   virtual bool SerializeData(std::string* data) OVERRIDE;
 
   // Clears any existing non-static entries, and then re-populates
   // |transport_security_state_|.
   //
   // Sets |*dirty| to true if the new state differs from the persisted
   // state; false otherwise.
   bool LoadEntries(const std::string& serialized, bool* dirty);
 
  private:
-  class Loader;
-
   // Populates |state| from the JSON string |serialized|. Returns true if
   // all entries were parsed and deserialized correctly.
   //
   // Sets |*dirty| to true if the new state differs from the persisted
   // state; false otherwise.
   static bool Deserialize(const std::string& serialized,
                           bool* dirty,
                           net::TransportSecurityState* state);
 
   void CompleteLoad(const std::string& state);
 
   net::TransportSecurityState* transport_security_state_;
 
   // Helper for safely writing the data.
   base::ImportantFileWriter writer_;
 
+  scoped_refptr<base::SequencedTaskRunner> foreground_runner_;
+  scoped_refptr<base::SequencedTaskRunner> background_runner_;

[battre, 2013/11/05 11:54:36]

Add comments that foreground is IO thread and background is file thread? Maybe
even rename them accordingly?

[Aaron Boodman, 2013/11/06 21:57:06]

In Mojo, this class isn't necessarily created on the IO thread. I'd rather not
couple the implementation to its usage in Chrome.

+
   // Whether or not we're in read-only mode.
   const bool readonly_;
 
   base::WeakPtrFactory<TransportSecurityPersister> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(TransportSecurityPersister);
 };
 
 #endif  // CHROME_BROWSER_NET_TRANSPORT_SECURITY_PERSISTER_H_