Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 579893002: Remove USE_X11 check in DragDropTracker unittests (Closed)

Created:
6 years, 3 months ago by dnicoara
Modified:
6 years, 3 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org, dcheng, mazda
Base URL:
https://chromium.googlesource.com/chromium/src.git@ash-cursor
Project:
chromium
Visibility:
Public.

Description

Remove USE_X11 check in DragDropTracker unittests BUG=401307 Committed: https://crrev.com/54f98657d48d67fdb4d0097e7a9f906cc52f9378 Cr-Commit-Position: refs/heads/master@{#295494}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -17 lines) Patch
M ash/drag_drop/drag_drop_tracker_unittest.cc View 1 2 3 chunks +8 lines, -17 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
dnicoara
I found these tests and they work just fine on Ozone. The issue of ash/wm/coordinate_conversion.h ...
6 years, 3 months ago (2014-09-18 16:48:06 UTC) #2
Daniel Erat
lgtm nice!
6 years, 3 months ago (2014-09-18 16:55:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/579893002/40001
6 years, 3 months ago (2014-09-18 17:25:13 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001) as df97549ad6d54389a910757c12cbc3e41b001a15
6 years, 3 months ago (2014-09-18 17:58:34 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 17:59:10 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/54f98657d48d67fdb4d0097e7a9f906cc52f9378
Cr-Commit-Position: refs/heads/master@{#295494}

Powered by Google App Engine
This is Rietveld 408576698