Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1764)

Unified Diff: ash/drag_drop/drag_drop_tracker_unittest.cc

Issue 579893002: Remove USE_X11 check in DragDropTracker unittests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ash-cursor
Patch Set: . Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/drag_drop/drag_drop_tracker_unittest.cc
diff --git a/ash/drag_drop/drag_drop_tracker_unittest.cc b/ash/drag_drop/drag_drop_tracker_unittest.cc
index 6b470e89c544b0ef5d3f34e127dd31ad04cd6087..24c5e89b3d3897031ac84c7e036018f019d776da 100644
--- a/ash/drag_drop/drag_drop_tracker_unittest.cc
+++ b/ash/drag_drop/drag_drop_tracker_unittest.cc
@@ -19,7 +19,6 @@ class DragDropTrackerTest : public test::AshTestBase {
public:
virtual void SetUp() OVERRIDE {
AshTestBase::SetUp();
- UpdateDisplay("200x200,300x300");
}
aura::Window* CreateTestWindow(const gfx::Rect& bounds) {
@@ -51,15 +50,11 @@ class DragDropTrackerTest : public test::AshTestBase {
}
};
-// TODO(mazda): Remove this once ash/wm/coordinate_conversion.h supports
-// non-X11 platforms.
-#if defined(USE_X11)
-#define MAYBE_GetTarget GetTarget
-#else
-#define MAYBE_GetTarget DISABLED_GetTarget
-#endif
+TEST_F(DragDropTrackerTest, GetTarget) {
+ if (!SupportsMultipleDisplays())
dnicoara 2014/09/18 16:48:06 This is needed since Windows doesn't support multi
+ return;
-TEST_F(DragDropTrackerTest, MAYBE_GetTarget) {
+ UpdateDisplay("200x200,300x300");
aura::Window::Windows root_windows = Shell::GetAllRootWindows();
EXPECT_EQ(2U, root_windows.size());
@@ -118,15 +113,11 @@ TEST_F(DragDropTrackerTest, MAYBE_GetTarget) {
EXPECT_NE(window1.get(), GetTarget(gfx::Point(50, 50)));
}
-// TODO(mazda): Remove this once ash/wm/coordinate_conversion.h supports
-// non-X11 platforms.
-#if defined(USE_X11)
-#define MAYBE_ConvertEvent ConvertEvent
-#else
-#define MAYBE_ConvertEvent DISABLED_ConvertEvent
-#endif
+TEST_F(DragDropTrackerTest, ConvertEvent) {
+ if (!SupportsMultipleDisplays())
+ return;
-TEST_F(DragDropTrackerTest, MAYBE_ConvertEvent) {
+ UpdateDisplay("200x200,300x300");
aura::Window::Windows root_windows = Shell::GetAllRootWindows();
EXPECT_EQ(2U, root_windows.size());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698