Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1227)

Issue 579883002: Use Manifest's orientation when creating a shortcut and as default orientation. (Closed)

Created:
6 years, 3 months ago by mlamouri (slow - plz ping)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@use_display_in_shortcuthelper
Project:
chromium
Visibility:
Public.

Description

Use Manifest's orientation when creating a shortcut and as default orientation. The orientation's value will be passed to the shortcut intent and will then be used when trying to find out the default orientation. BUG=366145 TBR=eseidel@chromium.org (for chrome/browser/DEPS change) Committed: https://crrev.com/350ce8afc8e4a34c1bb2f51659a7ae9c329a7918 Cr-Commit-Position: refs/heads/master@{#295498}

Patch Set 1 #

Total comments: 8

Patch Set 2 : review comments #

Patch Set 3 : use ScreenOrientationConstants.EXTRA_ORIENTATION. #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -19 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java View 1 2 4 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/shortcut_helper.h View 3 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/android/shortcut_helper.cc View 1 5 chunks +16 lines, -3 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ScreenOrientationProvider.java View 1 2 4 chunks +40 lines, -12 lines 0 comments Download
A content/public/android/java/src/org/chromium/content_public/common/ScreenOrientationConstants.java View 1 2 3 4 1 chunk +18 lines, -0 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/gfx/DeviceDisplayInfo.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 26 (5 generated)
mlamouri (slow - plz ping)
dfalcantara@ and tedchoc@, could you both review all the changes?
6 years, 3 months ago (2014-09-17 19:50:11 UTC) #2
gone
On 2014/09/17 19:50:11, Mounir Lamouri wrote: > dfalcantara@ and tedchoc@, could you both review all ...
6 years, 3 months ago (2014-09-18 06:06:55 UTC) #3
mlamouri (slow - plz ping)
6 years, 3 months ago (2014-09-18 09:44:41 UTC) #5
Bernhard Bauer
Just some nits: https://codereview.chromium.org/579883002/diff/1/content/public/android/java/src/org/chromium/content/browser/ScreenOrientationProvider.java File content/public/android/java/src/org/chromium/content/browser/ScreenOrientationProvider.java (right): https://codereview.chromium.org/579883002/diff/1/content/public/android/java/src/org/chromium/content/browser/ScreenOrientationProvider.java#newcode36 content/public/android/java/src/org/chromium/content/browser/ScreenOrientationProvider.java:36: Activity activity) { We don't actually ...
6 years, 3 months ago (2014-09-18 10:03:03 UTC) #6
mlamouri (slow - plz ping)
https://codereview.chromium.org/579883002/diff/1/content/public/android/java/src/org/chromium/content/browser/ScreenOrientationProvider.java File content/public/android/java/src/org/chromium/content/browser/ScreenOrientationProvider.java (right): https://codereview.chromium.org/579883002/diff/1/content/public/android/java/src/org/chromium/content/browser/ScreenOrientationProvider.java#newcode36 content/public/android/java/src/org/chromium/content/browser/ScreenOrientationProvider.java:36: Activity activity) { On 2014/09/18 10:03:03, Bernhard Bauer wrote: ...
6 years, 3 months ago (2014-09-18 10:16:09 UTC) #7
mlamouri (slow - plz ping)
PTAL
6 years, 3 months ago (2014-09-18 10:16:22 UTC) #8
Bernhard Bauer
lgtm
6 years, 3 months ago (2014-09-18 10:43:18 UTC) #9
mlamouri (slow - plz ping)
Miguel, could you have a look at: ui/android/java/src/org/chromium/ui/gfx/DeviceDisplayInfo.java Thanks :)
6 years, 3 months ago (2014-09-18 10:53:09 UTC) #11
Miguel Garcia
lgtm for DeviceDisplayInfo.java
6 years, 3 months ago (2014-09-18 11:16:01 UTC) #12
mlamouri (slow - plz ping)
Bernhard, PTAL
6 years, 3 months ago (2014-09-18 14:50:49 UTC) #13
Bernhard Bauer
Nice! https://codereview.chromium.org/579883002/diff/60001/content/public/android/java/src/org/chromium/content_public/common/ScreenOrientationConstants.java File content/public/android/java/src/org/chromium/content_public/common/ScreenOrientationConstants.java (right): https://codereview.chromium.org/579883002/diff/60001/content/public/android/java/src/org/chromium/content_public/common/ScreenOrientationConstants.java#newcode11 content/public/android/java/src/org/chromium/content_public/common/ScreenOrientationConstants.java:11: public class ScreenOrientationConstants { Add a private empty ...
6 years, 3 months ago (2014-09-18 16:11:37 UTC) #14
mlamouri (slow - plz ping)
Applied. PTAL.
6 years, 3 months ago (2014-09-18 16:15:54 UTC) #15
Bernhard Bauer
LGTM, thanks!
6 years, 3 months ago (2014-09-18 16:22:43 UTC) #16
mlamouri (slow - plz ping)
+benm@ for the ScreenOrientationConstants.java addition.
6 years, 3 months ago (2014-09-18 17:21:07 UTC) #18
gone
Of course the nits didn't get sent... https://codereview.chromium.org/579883002/diff/1/content/public/android/java/src/org/chromium/content/browser/ScreenOrientationProvider.java File content/public/android/java/src/org/chromium/content/browser/ScreenOrientationProvider.java (right): https://codereview.chromium.org/579883002/diff/1/content/public/android/java/src/org/chromium/content/browser/ScreenOrientationProvider.java#newcode36 content/public/android/java/src/org/chromium/content/browser/ScreenOrientationProvider.java:36: Activity activity) ...
6 years, 3 months ago (2014-09-18 17:21:41 UTC) #19
benm (inactive)
content/public/android/java/src/org/chromium/content_public/common lgtm
6 years, 3 months ago (2014-09-18 17:25:28 UTC) #20
mlamouri (slow - plz ping)
On 2014/09/18 17:21:41, dfalcantara wrote: > Of course the nits didn't get sent... > > ...
6 years, 3 months ago (2014-09-18 17:38:23 UTC) #21
gone
On 2014/09/18 17:38:23, Mounir Lamouri wrote: > On 2014/09/18 17:21:41, dfalcantara wrote: > > Of ...
6 years, 3 months ago (2014-09-18 17:39:21 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/579883002/80001
6 years, 3 months ago (2014-09-18 17:44:16 UTC) #24
commit-bot: I haz the power
Committed patchset #5 (id:80001) as 418ddb0bf8cea635e460c7c3621e6f63c9685a8d
6 years, 3 months ago (2014-09-18 18:17:35 UTC) #25
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 18:18:15 UTC) #26
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/350ce8afc8e4a34c1bb2f51659a7ae9c329a7918
Cr-Commit-Position: refs/heads/master@{#295498}

Powered by Google App Engine
This is Rietveld 408576698