Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3847)

Unified Diff: chrome/browser/android/shortcut_helper.h

Issue 579883002: Use Manifest's orientation when creating a shortcut and as default orientation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@use_display_in_shortcuthelper
Patch Set: review comments Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/DEPS ('k') | chrome/browser/android/shortcut_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/shortcut_helper.h
diff --git a/chrome/browser/android/shortcut_helper.h b/chrome/browser/android/shortcut_helper.h
index 099293f295dea5eb0669fd334e31386cd9bcea87..48009608c1f622ad46add5cdb937d5f210d006d6 100644
--- a/chrome/browser/android/shortcut_helper.h
+++ b/chrome/browser/android/shortcut_helper.h
@@ -14,6 +14,7 @@
#include "components/favicon_base/favicon_types.h"
#include "content/public/browser/web_contents_observer.h"
#include "content/public/common/manifest.h"
+#include "third_party/WebKit/public/platform/WebScreenOrientationLockType.h"
namespace content {
class WebContents;
@@ -69,7 +70,8 @@ class ShortcutHelper : public content::WebContentsObserver {
const GURL& url,
const base::string16& title,
content::Manifest::DisplayMode display,
- const favicon_base::FaviconRawBitmapResult& bitmap_result);
+ const favicon_base::FaviconRawBitmapResult& bitmap_result,
+ blink::WebScreenOrientationLockType orientation);
// Registers JNI hooks.
static bool RegisterShortcutHelper(JNIEnv* env);
@@ -87,6 +89,7 @@ class ShortcutHelper : public content::WebContentsObserver {
content::Manifest::DisplayMode display_;
favicon_base::FaviconRawBitmapResult icon_;
base::CancelableTaskTracker cancelable_task_tracker_;
+ blink::WebScreenOrientationLockType orientation_;
base::WeakPtrFactory<ShortcutHelper> weak_ptr_factory_;
« no previous file with comments | « chrome/browser/DEPS ('k') | chrome/browser/android/shortcut_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698