Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 579863004: CC: Add fill mode to compositor animations (Closed)

Created:
6 years, 3 months ago by samli
Modified:
6 years, 3 months ago
Reviewers:
dstockwell, ajuma
CC:
cc-bugs_chromium.org, chromium-reviews, dstockwell
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

CC: Add fill mode to compositor animations BUG=415241 Committed: https://crrev.com/f671117965e68d5b309bd8ea401aeb90023bdb3d Cr-Commit-Position: refs/heads/master@{#295614}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Review changes #

Patch Set 3 : Rebase #

Patch Set 4 : Fix compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -23 lines) Patch
M cc/animation/animation.h View 1 2 5 chunks +15 lines, -0 lines 0 comments Download
M cc/animation/animation.cc View 1 2 4 chunks +18 lines, -7 lines 0 comments Download
M cc/animation/animation_unittest.cc View 1 2 3 1 chunk +46 lines, -0 lines 0 comments Download
M cc/animation/layer_animation_controller.cc View 1 2 chunks +6 lines, -0 lines 0 comments Download
M cc/blink/web_animation_impl.h View 1 2 2 chunks +4 lines, -6 lines 0 comments Download
M cc/blink/web_animation_impl.cc View 1 2 3 chunks +35 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
samli
6 years, 3 months ago (2014-09-18 00:02:31 UTC) #2
dstockwell
https://codereview.chromium.org/579863004/diff/1/cc/animation/animation.cc File cc/animation/animation.cc (right): https://codereview.chromium.org/579863004/diff/1/cc/animation/animation.cc#newcode162 cc/animation/animation.cc:162: bool Animation::NoEffectBeforeAnimation(base::TimeTicks monotonic_time) const { This method name is ...
6 years, 3 months ago (2014-09-18 00:14:30 UTC) #4
samli
https://codereview.chromium.org/579863004/diff/1/cc/animation/animation.cc File cc/animation/animation.cc (right): https://codereview.chromium.org/579863004/diff/1/cc/animation/animation.cc#newcode162 cc/animation/animation.cc:162: bool Animation::NoEffectBeforeAnimation(base::TimeTicks monotonic_time) const { On 2014/09/18 00:14:29, dstockwell ...
6 years, 3 months ago (2014-09-18 00:59:56 UTC) #5
ajuma
lgtm
6 years, 3 months ago (2014-09-18 18:53:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/579863004/60001
6 years, 3 months ago (2014-09-18 22:17:05 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001) as 3f5f44ae39885ea9b8698cd30967f08f1590b8f1
6 years, 3 months ago (2014-09-19 00:01:16 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 00:02:25 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/f671117965e68d5b309bd8ea401aeb90023bdb3d
Cr-Commit-Position: refs/heads/master@{#295614}

Powered by Google App Engine
This is Rietveld 408576698