Add mixin support to source mirrors.

Add mixin support to source mirrors.

BUG=
R=karlklose@google.com

Committed: https://code.google.com/p/dart/source/detail?r=29890

[karlklose, 2013-11-05 10:34:17]

LGTM with a few comments about names.

https://codereview.chromium.org/57983002/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart
(right):

https://codereview.chromium.org/57983002/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart:974:
ClassMirror get mixin => this;
Add a TODO about removing this?

https://codereview.chromium.org/57983002/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/mirrors/mirrors_util.dart
(right):

https://codereview.chromium.org/57983002/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/mirrors/mirrors_util.dart:191:
ClassMirror getExtends(ClassMirror cls) {
Change to 'getSuperclass'?

https://codereview.chromium.org/57983002/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/mirrors/mirrors_util.dart:210:
Iterable<ClassMirror> getWith(ClassMirror cls) {
Change to 'getAppliedMixins'?

https://codereview.chromium.org/57983002/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/mirrors/mirrors_util.dart:236:
Iterable<ClassMirror> getImplements(ClassMirror cls) {
Change to 'getExplicitInterfaces' or something similar?

https://codereview.chromium.org/57983002/diff/1/tests/compiler/dart2js/mirror...
File tests/compiler/dart2js/mirror_system_helper.dart (right):

https://codereview.chromium.org/57983002/diff/1/tests/compiler/dart2js/mirror...
tests/compiler/dart2js/mirror_system_helper.dart:35: bool isType(ClassMirror
decl, List<TypeMirror> typeArguments,
'isInstance'?

https://codereview.chromium.org/57983002/diff/1/tests/compiler/dart2js/mirror...
tests/compiler/dart2js/mirror_system_helper.dart:46: bool equalsType(TypeMirror
expected, TypeMirror type) {
'isEqualType'?

https://codereview.chromium.org/57983002/diff/1/tests/compiler/dart2js/mirror...
tests/compiler/dart2js/mirror_system_helper.dart:62: bool
equalsTypes(List<TypeMirror> expected, List<TypeMirror> types) {
Ditto.

https://codereview.chromium.org/57983002/diff/1/tests/compiler/dart2js/mirror...
tests/compiler/dart2js/mirror_system_helper.dart:72: for (var type in types) {
types.any((type) => isType(decl, typeArguments, type));

https://codereview.chromium.org/57983002/diff/1/tests/compiler/dart2js/mirror...
tests/compiler/dart2js/mirror_system_helper.dart:83: TypeMirror
toDecl(TypeMirror type) {
'Decl' -> 'Declaration'? (also multiple times below)

https://codereview.chromium.org/57983002/diff/1/tests/compiler/dart2js/mirror...
File tests/compiler/dart2js/mirrors_mixin_test.dart (right):

https://codereview.chromium.org/57983002/diff/1/tests/compiler/dart2js/mirror...
tests/compiler/dart2js/mirrors_mixin_test.dart:35: Expect.isNotNull(A);
You could write test methods that takes the expectations for all these tests as
named arguments to share the code for the tests.

https://codereview.chromium.org/57983002/diff/1/tests/compiler/dart2js/mirror...
tests/compiler/dart2js/mirrors_mixin_test.dart:96:
Expect.isFalse(!C_super.isNameSynthetic);
Why this double negation?

[Johnni Winther, 2013-11-05 11:20:46]

https://codereview.chromium.org/57983002/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart
(right):

https://codereview.chromium.org/57983002/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart:974:
ClassMirror get mixin => this;
On 2013/11/05 10:34:18, karlklose wrote:
> Add a TODO about removing this?

Done.

https://codereview.chromium.org/57983002/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/mirrors/mirrors_util.dart
(right):

https://codereview.chromium.org/57983002/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/mirrors/mirrors_util.dart:191:
ClassMirror getExtends(ClassMirror cls) {
On 2013/11/05 10:34:18, karlklose wrote:
> Change to 'getSuperclass'?

Done.

https://codereview.chromium.org/57983002/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/mirrors/mirrors_util.dart:210:
Iterable<ClassMirror> getWith(ClassMirror cls) {
On 2013/11/05 10:34:18, karlklose wrote:
> Change to 'getAppliedMixins'?

Done.

https://codereview.chromium.org/57983002/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/mirrors/mirrors_util.dart:236:
Iterable<ClassMirror> getImplements(ClassMirror cls) {
On 2013/11/05 10:34:18, karlklose wrote:
> Change to 'getExplicitInterfaces' or something similar?

Done.

https://codereview.chromium.org/57983002/diff/1/tests/compiler/dart2js/mirror...
File tests/compiler/dart2js/mirror_system_helper.dart (right):

https://codereview.chromium.org/57983002/diff/1/tests/compiler/dart2js/mirror...
tests/compiler/dart2js/mirror_system_helper.dart:35: bool isType(ClassMirror
decl, List<TypeMirror> typeArguments,
On 2013/11/05 10:34:18, karlklose wrote:
> 'isInstance'?

Done.

https://codereview.chromium.org/57983002/diff/1/tests/compiler/dart2js/mirror...
tests/compiler/dart2js/mirror_system_helper.dart:46: bool equalsType(TypeMirror
expected, TypeMirror type) {
On 2013/11/05 10:34:18, karlklose wrote:
> 'isEqualType'?

Done.

https://codereview.chromium.org/57983002/diff/1/tests/compiler/dart2js/mirror...
tests/compiler/dart2js/mirror_system_helper.dart:62: bool
equalsTypes(List<TypeMirror> expected, List<TypeMirror> types) {
On 2013/11/05 10:34:18, karlklose wrote:
> Ditto.

Done.

https://codereview.chromium.org/57983002/diff/1/tests/compiler/dart2js/mirror...
tests/compiler/dart2js/mirror_system_helper.dart:72: for (var type in types) {
On 2013/11/05 10:34:18, karlklose wrote:
> types.any((type) => isType(decl, typeArguments, type));

Done.

https://codereview.chromium.org/57983002/diff/1/tests/compiler/dart2js/mirror...
tests/compiler/dart2js/mirror_system_helper.dart:83: TypeMirror
toDecl(TypeMirror type) {
On 2013/11/05 10:34:18, karlklose wrote:
> 'Decl' -> 'Declaration'? (also multiple times below)

Done.

https://codereview.chromium.org/57983002/diff/1/tests/compiler/dart2js/mirror...
File tests/compiler/dart2js/mirrors_mixin_test.dart (right):

https://codereview.chromium.org/57983002/diff/1/tests/compiler/dart2js/mirror...
tests/compiler/dart2js/mirrors_mixin_test.dart:35: Expect.isNotNull(A);
On 2013/11/05 10:34:18, karlklose wrote:
> You could write test methods that takes the expectations for all these tests
as
> named arguments to share the code for the tests.

Done.

https://codereview.chromium.org/57983002/diff/1/tests/compiler/dart2js/mirror...
tests/compiler/dart2js/mirrors_mixin_test.dart:96:
Expect.isFalse(!C_super.isNameSynthetic);
On 2013/11/05 10:34:18, karlklose wrote:
> Why this double negation?

An artifact of code motion. Fixed.

[Johnni Winther, 2013-11-05 11:27:33]

Committed patchset #2 manually as r29890 (presubmit successful).