Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 579753002: Removing onBookmarkChanged notification to application on history change and added proper history c… (Closed)

Created:
6 years, 3 months ago by kn.darshini
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Removing onBookmarkChanged notification to application on history change and added proper history change notification on history data change. BUG=None Committed: https://crrev.com/cd15c85b2fcea1408f526dcea518f4aeb5500416 Cr-Commit-Position: refs/heads/master@{#295651}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProvider.java View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/android/provider/chrome_browser_provider.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
jochen (gone - plz use gerrit)
thanks for the patch could you please pick a reviewer from an OWNERS file closer ...
6 years, 3 months ago (2014-09-17 18:16:45 UTC) #2
kn.darshini
On 2014/09/17 18:16:45, jochen wrote: > thanks for the patch > > could you please ...
6 years, 3 months ago (2014-09-18 04:38:11 UTC) #4
Bernhard Bauer
LGTM, but please pick a single reviewer next time.
6 years, 3 months ago (2014-09-18 08:17:20 UTC) #5
kn.darshini
On 2014/09/18 08:17:20, Bernhard Bauer wrote: > LGTM, but please pick a single reviewer next ...
6 years, 3 months ago (2014-09-18 09:42:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/579753002/1
6 years, 3 months ago (2014-09-18 09:50:07 UTC) #8
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-18 12:39:44 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/579753002/1
6 years, 3 months ago (2014-09-19 02:29:49 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1) as 6aaf6386bfd98c145d8204a02dd8adb41ea2242e
6 years, 3 months ago (2014-09-19 03:27:52 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 03:29:05 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cd15c85b2fcea1408f526dcea518f4aeb5500416
Cr-Commit-Position: refs/heads/master@{#295651}

Powered by Google App Engine
This is Rietveld 408576698