Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Side by Side Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProvider.java

Issue 579753002: Removing onBookmarkChanged notification to application on history change and added proper history c… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « AUTHORS ('k') | chrome/browser/android/provider/chrome_browser_provider.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.chrome.browser; 5 package org.chromium.chrome.browser;
6 6
7 import android.annotation.SuppressLint; 7 import android.annotation.SuppressLint;
8 import android.app.SearchManager; 8 import android.app.SearchManager;
9 import android.content.ContentProvider; 9 import android.content.ContentProvider;
10 import android.content.ContentUris; 10 import android.content.ContentUris;
(...skipping 1027 matching lines...) Expand 10 before | Expand all | Expand 10 after
1038 private int removeHistoryFromAPI(String selection, String[] selectionArgs) { 1038 private int removeHistoryFromAPI(String selection, String[] selectionArgs) {
1039 return nativeRemoveHistoryFromAPI(mNativeChromeBrowserProvider, selectio n, selectionArgs); 1039 return nativeRemoveHistoryFromAPI(mNativeChromeBrowserProvider, selectio n, selectionArgs);
1040 } 1040 }
1041 1041
1042 @CalledByNative 1042 @CalledByNative
1043 private void onBookmarkChanged() { 1043 private void onBookmarkChanged() {
1044 notifyChange(buildAPIContentUri(getContext(), BOOKMARKS_PATH)); 1044 notifyChange(buildAPIContentUri(getContext(), BOOKMARKS_PATH));
1045 } 1045 }
1046 1046
1047 @CalledByNative 1047 @CalledByNative
1048 private void onHistoryChanged() {
1049 notifyChange(buildAPIContentUri(getContext(), HISTORY_PATH));
1050 }
1051
1052 @CalledByNative
1048 private void onSearchTermChanged() { 1053 private void onSearchTermChanged() {
1049 notifyChange(buildAPIContentUri(getContext(), SEARCHES_PATH)); 1054 notifyChange(buildAPIContentUri(getContext(), SEARCHES_PATH));
1050 } 1055 }
1051 1056
1052 private long addSearchTermFromAPI(ContentValues values) { 1057 private long addSearchTermFromAPI(ContentValues values) {
1053 SearchRow row = SearchRow.fromContentValues(values); 1058 SearchRow row = SearchRow.fromContentValues(values);
1054 if (row.mTerm == null) { 1059 if (row.mTerm == null) {
1055 throw new IllegalArgumentException("Must have a search term"); 1060 throw new IllegalArgumentException("Must have a search term");
1056 } 1061 }
1057 return nativeAddSearchTermFromAPI(mNativeChromeBrowserProvider, row.mTer m, row.mDate); 1062 return nativeAddSearchTermFromAPI(mNativeChromeBrowserProvider, row.mTer m, row.mDate);
(...skipping 291 matching lines...) Expand 10 before | Expand all | Expand 10 after
1349 1354
1350 private native BookmarkNode nativeGetMobileBookmarksFolder(long nativeChrome BrowserProvider); 1355 private native BookmarkNode nativeGetMobileBookmarksFolder(long nativeChrome BrowserProvider);
1351 1356
1352 private native boolean nativeIsBookmarkInMobileBookmarksBranch(long nativeCh romeBrowserProvider, 1357 private native boolean nativeIsBookmarkInMobileBookmarksBranch(long nativeCh romeBrowserProvider,
1353 long id); 1358 long id);
1354 1359
1355 private native byte[] nativeGetFaviconOrTouchIcon(long nativeChromeBrowserPr ovider, String url); 1360 private native byte[] nativeGetFaviconOrTouchIcon(long nativeChromeBrowserPr ovider, String url);
1356 1361
1357 private native byte[] nativeGetThumbnail(long nativeChromeBrowserProvider, S tring url); 1362 private native byte[] nativeGetThumbnail(long nativeChromeBrowserProvider, S tring url);
1358 } 1363 }
OLDNEW
« no previous file with comments | « AUTHORS ('k') | chrome/browser/android/provider/chrome_browser_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698