Service Worker:Layouttests:Remove wrong done() call from serviceworkerobject-scripturl.html

Service Worker:Layouttests:Remove wrong done() call from serviceworkerobject-scripturl.html

1. Due to misplace "t.done()", get the undefined registration,and the assert_equals will always be not excuted.

R=nhiroki@chromium.org, dominicc@chromium.org, yhirano@chromium.org
BUG=414599
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182215

[qi1988.yang, 2014-09-17 09:08:18]

Please take a look, thanks!

[yhirano, 2014-09-17 09:11:42]

https://codereview.chromium.org/579693002/diff/1/LayoutTests/http/tests/servi...
File LayoutTests/http/tests/serviceworker/serviceworkerobject-scripturl.html
(right):

https://codereview.chromium.org/579693002/diff/1/LayoutTests/http/tests/servi...
LayoutTests/http/tests/serviceworker/serviceworkerobject-scripturl.html:20:
t.done();
I think calling t.done is needless because it is scheduled in
service_worker_unregister_and_done.

[qi1988.yang, 2014-09-17 09:48:08]

Please have a check again,thanks!

https://codereview.chromium.org/579693002/diff/1/LayoutTests/http/tests/servi...
File LayoutTests/http/tests/serviceworker/serviceworkerobject-scripturl.html
(right):

https://codereview.chromium.org/579693002/diff/1/LayoutTests/http/tests/servi...
LayoutTests/http/tests/serviceworker/serviceworkerobject-scripturl.html:20:
t.done();
On 2014/09/17 09:11:42, yhirano wrote:
> I think calling t.done is needless because it is scheduled in
> service_worker_unregister_and_done.

Done.

[nhiroki, 2014-09-17 10:06:18]

Thank you for working on this!

nit: Can you change the CL title to explain the behavior of this patch. For
example, "Remove wrong done() call from serviceworkerobject-scripturl.html".

nit: There is an unknown string in the CL description ("it
969640529fbfe613c7cabf3a4cada6f69081c3b1"). Can you remove it if not necessary?

https://codereview.chromium.org/579693002/diff/20001/LayoutTests/http/tests/s...
File LayoutTests/http/tests/serviceworker/serviceworkerobject-scripturl.html
(right):

https://codereview.chromium.org/579693002/diff/20001/LayoutTests/http/tests/s...
LayoutTests/http/tests/serviceworker/serviceworkerobject-scripturl.html:20: }));
Can you append '.catch(unreached_rejection(t));' to handle a rejection case?

[qi1988.yang, 2014-09-17 11:05:59]

https://codereview.chromium.org/579693002/diff/20001/LayoutTests/http/tests/s...
File LayoutTests/http/tests/serviceworker/serviceworkerobject-scripturl.html
(right):

https://codereview.chromium.org/579693002/diff/20001/LayoutTests/http/tests/s...
LayoutTests/http/tests/serviceworker/serviceworkerobject-scripturl.html:20: }));
On 2014/09/17 10:06:18, nhiroki wrote:
> Can you append '.catch(unreached_rejection(t));' to handle a rejection case?

Acknowledged.

[nhiroki, 2014-09-17 11:23:07]

LGTM, thanks!

[yhirano, 2014-09-17 12:06:14]

lgtm

[dominicc (has gone to gerrit), 2014-09-17 12:23:46]

dominicc@chromium.org changed reviewers:
- dominicc@chromium.org

[qi1988.yang, 2014-09-18 01:46:33]

The CQ bit was checked by qi1988.yang@samsung.com

[qi1988.yang, 2014-09-18 01:46:41]

The CQ bit was unchecked by qi1988.yang@samsung.com

[qi1988.yang, 2014-09-18 01:46:42]

The CQ bit was checked by qi1988.yang@samsung.com

[commit-bot: I haz the power, 2014-09-18 01:47:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/579693002/40001

[commit-bot: I haz the power, 2014-09-18 03:00:26]

Committed patchset #3 (id:40001) as 182215