LayoutTests/http/tests/serviceworker/serviceworkerobject-scripturl.html - Issue 579693002: Service Worker:Layouttests:Remove wrong done() call from serviceworkerobject-scripturl.html

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/serviceworker/serviceworkerobject-scripturl.html

Issue 579693002: Service Worker:Layouttests:Remove wrong done() call from serviceworkerobject-scripturl.html (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | no next file » | no next file with comments »

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <title>ServiceWorker object: scriptURL property</title>	2 <title>ServiceWorker object: scriptURL property</title>

3 <script src="../resources/testharness.js"></script>	3 <script src="../resources/testharness.js"></script>

4 <script src="../resources/testharnessreport.js"></script>	4 <script src="../resources/testharnessreport.js"></script>

5 <script src="resources/test-helpers.js"></script>	5 <script src="resources/test-helpers.js"></script>

6 <script>	6 <script>

7	7

8 function url_test(name, url) {	8 function url_test(name, url) {

9 var scope = 'scope/' + name;	9 var scope = 'scope/' + name;

10 async_test(function(t) {	10 async_test(function(t) {

11 var expectedURL = normalizeURL(url);	11 var expectedURL = normalizeURL(url);

12 service_worker_unregister_and_register(t, url, scope)	12 service_worker_unregister_and_register(t, url, scope)

13 .then(function(registration) {	13 .then(function(registration) {

14 return wait_for_update(t, registration);	14 return wait_for_update(t, registration);

15 })	15 })

16 .then(t.step_func(function(worker) {	16 .then(t.step_func(function(worker) {

17 assert_equals(worker.scriptURL, expectedURL,	17 assert_equals(worker.scriptURL, expectedURL,

18 'Returned ServiceWorker object should have scriptURL');	18 'Returned ServiceWorker object should have scriptURL');

19 service_worker_unregister_and_done(t, scope);	19 service_worker_unregister_and_done(t, scope);

	20 t.done();
	yhirano 2014/09/17 09:11:42 I think calling t.done is needless because it is s I think calling t.done is needless because it is scheduled in service_worker_unregister_and_done. qi1988.yang 2014/09/17 09:48:08 Done. Show quoted text On 2014/09/17 09:11:42, yhirano wrote: > I think calling t.done is needless because it is scheduled in > service_worker_unregister_and_done. Done.
20 }));	21 }));

21 t.done();

22 }, 'Verify the scriptURL property: ' + name);	22 }, 'Verify the scriptURL property: ' + name);

23 }	23 }

24	24

25 url_test('relative', 'resources/empty-worker.js');	25 url_test('relative', 'resources/empty-worker.js');

26 url_test('with-fragment', 'resources/empty-worker.js#ref');	26 url_test('with-fragment', 'resources/empty-worker.js#ref');

27 url_test('absolute',	27 url_test('absolute',

28 'http://127.0.0.1:8000/serviceworker/resources/empty-worker.js');	28 'http://127.0.0.1:8000/serviceworker/resources/empty-worker.js');

29	29

30 </script>	30 </script>

OLD	NEW