Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 579533003: Correctly fix a bug when a QUIC session is closed during the call to (Closed)

Created:
6 years, 3 months ago by Ryan Hamilton
Modified:
6 years, 3 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Correctly fix a bug when a QUIC session is closed during the call to InitializeSession. This seems to be able to happen if too much time elapses between the call to the constructor and the call to InitializeSession. This fixes the fix from https://codereview.chromium.org/560913002 BUG=399147 Committed: https://crrev.com/eaa3d4faf6ed16c97f3e4d7bc02e816960c6befe Cr-Commit-Position: refs/heads/master@{#295601}

Patch Set 1 #

Patch Set 2 : typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M net/quic/quic_stream_factory.cc View 1 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Ryan Hamilton
6 years, 3 months ago (2014-09-18 19:48:13 UTC) #2
ramant (doing other things)
lgtm
6 years, 3 months ago (2014-09-18 21:02:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/579533003/20001
6 years, 3 months ago (2014-09-18 21:04:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/579533003/20001
6 years, 3 months ago (2014-09-18 22:41:25 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as b1b3ce693c9eac21c7d7d21ae09b53cc9b4103c1
6 years, 3 months ago (2014-09-18 23:36:29 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 23:37:04 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/eaa3d4faf6ed16c97f3e4d7bc02e816960c6befe
Cr-Commit-Position: refs/heads/master@{#295601}

Powered by Google App Engine
This is Rietveld 408576698