Fix a bug when a QUIC session is closed during the call to InitializeSession. This seems to be able…

Fix a bug when a QUIC session is closed during the call to InitializeSession. This seems to be able to happen if too much time elapses between the call to the constructor and the call to InitializeSession.

Also adds a histogram to monitor the frequency of this situation.

BUG=399147
Committed: https://crrev.com/f29ee62eeb9057b81d4e6f690409b209df367c04
Cr-Commit-Position: refs/heads/master@{#294425}

[Ryan Hamilton, 2014-09-10 19:09:39]

rch@chromium.org changed reviewers:
+ asvitkine@chromium.org, jri@google.com

[Ryan Hamilton, 2014-09-10 19:09:39]

jri: net/
asvitkine: histograms

[Alexei Svitkine (slow), 2014-09-10 19:14:51]

lgtm % nit

https://codereview.chromium.org/560913002/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/560913002/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:16407: +    True if the QUIC session is
closed during the call to InitializeSession.
Nit: Mention when this is logged (i.e. on each InitializeSession call?).

[Ryan Hamilton, 2014-09-10 19:36:29]

Thanks!

https://codereview.chromium.org/560913002/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/560913002/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:16407: +    True if the QUIC session is
closed during the call to InitializeSession.
On 2014/09/10 19:14:51, Alexei Svitkine wrote:
> Nit: Mention when this is logged (i.e. on each InitializeSession call?).

Done.

[Jana, 2014-09-10 20:02:42]

jri@chromium.org changed reviewers:
+ jri@chromium.org

[Jana, 2014-09-10 20:02:43]

lgtm

LGTM. One question: Why does this happen? I imagine it is because the
constructor call is taking too long... but why? And what's too long?

[Ryan Hamilton, 2014-09-10 20:38:40]

On 2014/09/10 20:02:43, Jana wrote:
> lgtm
> 
> LGTM. One question: Why does this happen? I imagine it is because the
> constructor call is taking too long... but why? And what's too long?

Windows is slow,is my guess...  I think we're talking about 5 seconds. Could be
related to restart behavior with lots of tabs opening at once.

[Ryan Hamilton, 2014-09-10 20:38:43]

The CQ bit was checked by rch@chromium.org

[commit-bot: I haz the power, 2014-09-10 21:02:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rch@chromium.org/560913002/20001

[commit-bot: I haz the power, 2014-09-10 22:20:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-10 22:20:40]

Try jobs failed on following builders:
  mac_gpu_retina_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_tr...)

[Ryan Hamilton, 2014-09-11 14:43:17]

The CQ bit was checked by rch@chromium.org

[commit-bot: I haz the power, 2014-09-11 14:44:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/560913002/20001

[commit-bot: I haz the power, 2014-09-11 18:18:30]

Committed patchset #2 (id:20001) as c92664cd6099f4b176d70fc197871160823ba10f

[commit-bot: I haz the power, 2014-09-11 18:43:20]

Patchset 2 (id:??) landed as
https://crrev.com/f29ee62eeb9057b81d4e6f690409b209df367c04
Cr-Commit-Position: refs/heads/master@{#294425}