Revert of Enable V8 idle notification after commit.

Revert of Enable V8 idle notification after commit. (patchset #2 id:20001 of https://codereview.chromium.org/566733004/)

Reason for revert:
We suspect that this patch is the cause of renderer flakyness on Linux ChromiumOS.

https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%283%29/builds/36828/steps/interactive_ui_tests/logs/stdio

# Fatal error in ../../v8/src/heap/gc-idle-time-handler.cc, line 45
# CHECK(idle_time_in_ms > 0) failed
#

==== C stack trace ===============================

1: ??
2: ??
3: ??
4: v8::Isolate::IdleNotification(int)
5: content::RenderWidgetCompositor::DidCommit()
6: non-virtual thunk to content::RenderWidgetCompositor::DidCommit()
7: cc::LayerTreeHost::CommitComplete()
8: cc::ThreadProxy::BeginMainFrame(scoped_ptr<cc::ThreadProxy::BeginMainFrameAndCommitState, base::DefaultDeleter<cc::ThreadProxy::BeginMainFrameAndCommitState> >)
9: ??
10: ??
11: ??
12: ??
13: base::debug::TaskAnnotator::RunTask(char const*, char const*, base::PendingTask const&)
14: ??
15: ??
16: ??
17: ??
18: ??
19: ??
20: blink::Scheduler::executeHighPriorityTasks(WTF::Deque<blink::TracedTask, 0ul, WTF::DefaultAllocator>&)
21: blink::Scheduler::swapQueuesRunPendingTasksAndAllowHighPriorityTaskRunnerPosting()
22: ??
23: ??
24: ??
25: ??
26: ??
27: base::debug::TaskAnnotator::RunTask(char const*, char const*, base::PendingTask const&)
28: base::MessageLoop::RunTask(base::PendingTask const&)
29: base::MessageLoop::DeferOrRunPendingTask(base::PendingTask const&)
30: base::MessageLoop::DoWork()
31: base::MessagePumpDefault::Run(base::MessagePump::Delegate*)
32: base::MessageLoop::RunHandler()
33: base::RunLoop::Run()
34: base::MessageLoop::Run()
35: ??
36: ??
37: ??
38: ??
39: content::ContentMain(content::ContentMainParams const&)
40: ??
41: ??
42: ??
43: __libc_start_main
44: ??


Original issue's description:
> Enable V8 idle notification after commit.
> 
> Enable the notification by default. Change flag
> --send-v8-idle-notification-after-commit to
> --enable-v8-idle-notification-after-commit. Add new flag
> --disable-v8-idle-notification-after-commit to override enable or
> default.
> 
> R=jochen@chromium.org,hpayer@chromium.org,jamesr@chromium.org,danno@chromium.org
> BUG=414815
> 
> Committed: https://crrev.com/291fd86a7aabd22fb27409a56b34055e02ee0c62
> Cr-Commit-Position: refs/heads/master@{#295540}

TBR=danno@chromium.org,hpayer@chromium.org,jamesr@chromium.org,jochen@chromium.org,kbr@chromium.org,ernstm@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=414815

[Elliot Glaysher, 2014-09-18 23:07:01]

Created Revert of Enable V8 idle notification after commit.

[commit-bot: I haz the power, 2014-09-18 23:09:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/579423003/1

[commit-bot: I haz the power, 2014-09-18 23:11:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-18 23:11:19]

Failed to apply patch for content/renderer/gpu/render_widget_compositor.cc:
While running git apply --index -p1;
  error: patch failed: content/renderer/gpu/render_widget_compositor.cc:423
  error: content/renderer/gpu/render_widget_compositor.cc: patch does not apply

Patch:       content/renderer/gpu/render_widget_compositor.cc
Index: content/renderer/gpu/render_widget_compositor.cc
diff --git a/content/renderer/gpu/render_widget_compositor.cc
b/content/renderer/gpu/render_widget_compositor.cc
index
f32fcbbc16fd1c2233428560aa21175b655c662d..57f0ca05b23ac92f22a2fd7bdd43c554f2601027
100644
--- a/content/renderer/gpu/render_widget_compositor.cc
+++ b/content/renderer/gpu/render_widget_compositor.cc
@@ -423,13 +423,11 @@
                                                bool threaded)
     : threaded_(threaded),
       widget_(widget),
-      send_v8_idle_notification_after_commit_(true) {
+      send_v8_idle_notification_after_commit_(false) {
   CommandLine* cmd = CommandLine::ForCurrentProcess();
 
-  if (cmd->HasSwitch(switches::kEnableV8IdleNotificationAfterCommit))
+  if (cmd->HasSwitch(switches::kSendV8IdleNotificationAfterCommit))
     send_v8_idle_notification_after_commit_ = true;
-  if (cmd->HasSwitch(switches::kDisableV8IdleNotificationAfterCommit))
-    send_v8_idle_notification_after_commit_ = false;
 }
 
 RenderWidgetCompositor::~RenderWidgetCompositor() {}

[ernstm, 2014-09-18 23:15:25]

On 2014/09/18 23:11:19, I haz the power (commit-bot) wrote:
> Failed to apply patch for content/renderer/gpu/render_widget_compositor.cc:
> While running git apply --index -p1;
>   error: patch failed: content/renderer/gpu/render_widget_compositor.cc:423
>   error: content/renderer/gpu/render_widget_compositor.cc: patch does not
apply
> 
> Patch:       content/renderer/gpu/render_widget_compositor.cc
> Index: content/renderer/gpu/render_widget_compositor.cc
> diff --git a/content/renderer/gpu/render_widget_compositor.cc
> b/content/renderer/gpu/render_widget_compositor.cc
> index
>
f32fcbbc16fd1c2233428560aa21175b655c662d..57f0ca05b23ac92f22a2fd7bdd43c554f2601027
> 100644
> --- a/content/renderer/gpu/render_widget_compositor.cc
> +++ b/content/renderer/gpu/render_widget_compositor.cc
> @@ -423,13 +423,11 @@
>                                                 bool threaded)
>      : threaded_(threaded),
>        widget_(widget),
> -      send_v8_idle_notification_after_commit_(true) {
> +      send_v8_idle_notification_after_commit_(false) {
>    CommandLine* cmd = CommandLine::ForCurrentProcess();
>  
> -  if (cmd->HasSwitch(switches::kEnableV8IdleNotificationAfterCommit))
> +  if (cmd->HasSwitch(switches::kSendV8IdleNotificationAfterCommit))
>      send_v8_idle_notification_after_commit_ = true;
> -  if (cmd->HasSwitch(switches::kDisableV8IdleNotificationAfterCommit))
> -    send_v8_idle_notification_after_commit_ = false;
>  }
>  
>  RenderWidgetCompositor::~RenderWidgetCompositor() {}

This is already disabled on ToT.

[Elliot Glaysher, 2014-09-18 23:15:29]

Never mind, it looks like you've already flipped the flag backwards.