Enable V8 idle notification after commit.

Enable V8 idle notification after commit.

Enable the notification by default. Change flag
--send-v8-idle-notification-after-commit to
--enable-v8-idle-notification-after-commit. Add new flag
--disable-v8-idle-notification-after-commit to override enable or
default.

R=jochen@chromium.org,hpayer@chromium.org,jamesr@chromium.org,danno@chromium.org
BUG=414815
Committed: https://crrev.com/291fd86a7aabd22fb27409a56b34055e02ee0c62
Cr-Commit-Position: refs/heads/master@{#295540}

[ernstm, 2014-09-11 22:03:50]

PTAL

[jochen (gone - plz use gerrit), 2014-09-12 07:48:56]

lgtm.

[Hannes Payer (out of office), 2014-09-12 11:51:08]

lgtm

[ernstm, 2014-09-12 18:24:38]

The CQ bit was checked by ernstm@chromium.org

[commit-bot: I haz the power, 2014-09-12 18:30:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/566733004/1

[commit-bot: I haz the power, 2014-09-12 20:04:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-12 20:04:34]

Try jobs failed on following builders:
  linux_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_trigger...)

[ernstm, 2014-09-12 20:34:54]

The CQ bit was checked by ernstm@chromium.org

[commit-bot: I haz the power, 2014-09-12 20:35:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/566733004/1

[commit-bot: I haz the power, 2014-09-12 21:56:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-12 21:56:56]

Try jobs failed on following builders:
  mac_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_triggered...)

[Ken Russell (switch to Gerrit), 2014-09-12 23:55:11]

kbr@chromium.org changed reviewers:
+ kbr@chromium.org

[Ken Russell (switch to Gerrit), 2014-09-12 23:55:12]

FYI: unfortunately this patch is running into Issue 412876, which is being fixed
in https://codereview.chromium.org/566733004 . We need the other bug to be fixed
before this can be landed. It is great that this CL causes that problem to occur
much more reliably.

[ernstm, 2014-09-12 23:55:43]

This needs to wait until https://codereview.chromium.org/552303006/ fixes
crbug.com/407976.

[Ken Russell (switch to Gerrit), 2014-09-13 05:12:56]

On 2014/09/12 23:55:43, ernstm wrote:
> This needs to wait until https://codereview.chromium.org/552303006/ fixes
> crbug.com/407976.

Yes. Sorry I got the CL wrong in my comment above.

[jochen (gone - plz use gerrit), 2014-09-17 14:50:17]

On 2014/09/13 at 05:12:56, kbr wrote:
> On 2014/09/12 23:55:43, ernstm wrote:
> > This needs to wait until https://codereview.chromium.org/552303006/ fixes
> > crbug.com/407976.
> 
> Yes. Sorry I got the CL wrong in my comment above.

as mentioned via email, i think we should disable the faulty test and land the
patch as is, wdyt?

[ernstm, 2014-09-18 17:40:34]

The CQ bit was checked by ernstm@chromium.org

[commit-bot: I haz the power, 2014-09-18 17:41:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/566733004/1

[commit-bot: I haz the power, 2014-09-18 17:49:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-18 17:49:31]

Try jobs failed on following builders:
  linux_chromium_gn_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[ernstm, 2014-09-18 18:14:58]

The CQ bit was checked by ernstm@chromium.org

[commit-bot: I haz the power, 2014-09-18 18:15:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/566733004/20001

[commit-bot: I haz the power, 2014-09-18 19:33:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-18 19:33:48]

Try jobs failed on following builders:
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ernstm, 2014-09-18 19:42:16]

The CQ bit was checked by ernstm@chromium.org

[commit-bot: I haz the power, 2014-09-18 19:42:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/566733004/20001

[commit-bot: I haz the power, 2014-09-18 20:16:17]

Committed patchset #2 (id:20001) as f63deca92cba2529336defd6c847a0dfea68af62

[commit-bot: I haz the power, 2014-09-18 20:16:49]

Patchset 2 (id:??) landed as
https://crrev.com/291fd86a7aabd22fb27409a56b34055e02ee0c62
Cr-Commit-Position: refs/heads/master@{#295540}

[Elliot Glaysher, 2014-09-18 23:07:01]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/579423003/ by erg@chromium.org.

The reason for reverting is: We suspect that this patch is the cause of renderer
flakyness on Linux ChromiumOS.

https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...

# Fatal error in ../../v8/src/heap/gc-idle-time-handler.cc, line 45
# CHECK(idle_time_in_ms > 0) failed
#

==== C stack trace ===============================

1: ??
2: ??
3: ??
4: v8::Isolate::IdleNotification(int)
5: content::RenderWidgetCompositor::DidCommit()
6: non-virtual thunk to content::RenderWidgetCompositor::DidCommit()
7: cc::LayerTreeHost::CommitComplete()
8:
cc::ThreadProxy::BeginMainFrame(scoped_ptr<cc::ThreadProxy::BeginMainFrameAndCommitState,
base::DefaultDeleter<cc::ThreadProxy::BeginMainFrameAndCommitState> >)
9: ??
10: ??
11: ??
12: ??
13: base::debug::TaskAnnotator::RunTask(char const*, char const*,
base::PendingTask const&)
14: ??
15: ??
16: ??
17: ??
18: ??
19: ??
20: blink::Scheduler::executeHighPriorityTasks(WTF::Deque<blink::TracedTask,
0ul, WTF::DefaultAllocator>&)
21:
blink::Scheduler::swapQueuesRunPendingTasksAndAllowHighPriorityTaskRunnerPosting()
22: ??
23: ??
24: ??
25: ??
26: ??
27: base::debug::TaskAnnotator::RunTask(char const*, char const*,
base::PendingTask const&)
28: base::MessageLoop::RunTask(base::PendingTask const&)
29: base::MessageLoop::DeferOrRunPendingTask(base::PendingTask const&)
30: base::MessageLoop::DoWork()
31: base::MessagePumpDefault::Run(base::MessagePump::Delegate*)
32: base::MessageLoop::RunHandler()
33: base::RunLoop::Run()
34: base::MessageLoop::Run()
35: ??
36: ??
37: ??
38: ??
39: content::ContentMain(content::ContentMainParams const&)
40: ??
41: ??
42: ??
43: __libc_start_main
44: ??
.