Issue 579383004: Omit <include> lines over 80+ columns.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 579383004: Omit <include> lines over 80+ columns. (Closed)

Created:
6 years, 3 months ago by Dan Beam

Modified:
6 years, 3 months ago

Reviewers:
Dirk Pranke, M-A Ruel

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Project:
tools

Visibility:
Public.

Omit <include> lines over 80+ columns. R=dpranke@chromium.org BUG=none TEST=no whining about <include src="long/path/name.js"> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=292080

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	presubmit_canned_checks.py	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 6 (2 generated)

Dan Beam

i tried to add a test: https://codereview.chromium.org/592463003 i have no idea why it doesn't work.

6 years, 3 months ago (2014-09-20 03:30:06 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/579383004/1

6 years, 3 months ago (2014-09-23 00:40:11 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-23 00:42:25 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 292080