Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: presubmit_canned_checks.py

Issue 579383004: Omit <include> lines over 80+ columns. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: presubmit_canned_checks.py
diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py
index 011b982e1bff6179ca4442f41987e2c5e379c268..a90c5ca5f19583d0e4699ad0edbfbfc616ac4d45 100644
--- a/presubmit_canned_checks.py
+++ b/presubmit_canned_checks.py
@@ -364,6 +364,9 @@ def CheckLongLines(input_api, output_api, maxlen, source_file_filter=None):
if 'url(' in line and file_extension == 'css':
return True
+ if '<include' in line and file_extension in ('css', 'html', 'js'):
+ return True
+
return input_api.re.match(
r'.*[A-Za-z][A-Za-z_0-9]{%d,}.*' % long_symbol, line)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698