Chromium Code Reviews| Index: sdk/lib/_internal/compiler/js_lib/js_mirrors.dart |
| diff --git a/sdk/lib/_internal/compiler/js_lib/js_mirrors.dart b/sdk/lib/_internal/compiler/js_lib/js_mirrors.dart |
| index 03fc44a4a856083abd3b58843bcd2a84d2027236..157d916166140f5ed1cae5b5840cff94b11571a7 100644 |
| --- a/sdk/lib/_internal/compiler/js_lib/js_mirrors.dart |
| +++ b/sdk/lib/_internal/compiler/js_lib/js_mirrors.dart |
| @@ -2518,21 +2518,17 @@ class JsTypedefMirror extends JsDeclarationMirror implements TypedefMirror { |
| bool get hasReflectedType => throw new UnimplementedError(); |
| - Type get reflectedType => throw new UnimplementedError(); |
| + Type get reflectedType => createRuntimeType(_mangledName); |
| - // TODO(ahe): Implement this method. |
| + // TODO(floitsch): Implement this method. |
| List<TypeVariableMirror> get typeVariables => throw new UnimplementedError(); |
| - // TODO(ahe): Implement this method. |
| - List<TypeMirror> get typeArguments => throw new UnimplementedError(); |
| + List<TypeMirror> get typeArguments => const <TypeMirror>[]; |
|
karlklose
2014/09/19 10:39:51
Do you plan to create an InstantiatedJsTypedefMirr
floitsch
2014/09/19 11:42:09
They are needed by the createRuntimeType.
Might be
|
| - // TODO(ahe): Implement this method. |
| - bool get isOriginalDeclaration => throw new UnimplementedError(); |
| + bool get isOriginalDeclaration => true; |
| - // TODO(ahe): Implement this method. |
| - TypeMirror get originalDeclaration => throw new UnimplementedError(); |
| + TypeMirror get originalDeclaration => this; |
| - // TODO(ahe): Implement this method. |
|
karlklose
2014/09/19 10:39:51
Restore TODO (with 'ahe' -> 'floitsch').
floitsch
2014/09/19 11:42:09
Done.
|
| DeclarationMirror get owner => throw new UnimplementedError(); |
| // TODO(ahe): Implement this method. |