Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: sdk/lib/_internal/compiler/js_lib/js_mirrors.dart

Issue 579303003: dart2js: mirrors. Support Typedef.reflectedType. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Remove spurious field. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/lib/mirrors/typedef_reflected_type_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/js_lib/js_mirrors.dart
diff --git a/sdk/lib/_internal/compiler/js_lib/js_mirrors.dart b/sdk/lib/_internal/compiler/js_lib/js_mirrors.dart
index 03fc44a4a856083abd3b58843bcd2a84d2027236..157d916166140f5ed1cae5b5840cff94b11571a7 100644
--- a/sdk/lib/_internal/compiler/js_lib/js_mirrors.dart
+++ b/sdk/lib/_internal/compiler/js_lib/js_mirrors.dart
@@ -2518,21 +2518,17 @@ class JsTypedefMirror extends JsDeclarationMirror implements TypedefMirror {
bool get hasReflectedType => throw new UnimplementedError();
- Type get reflectedType => throw new UnimplementedError();
+ Type get reflectedType => createRuntimeType(_mangledName);
- // TODO(ahe): Implement this method.
+ // TODO(floitsch): Implement this method.
List<TypeVariableMirror> get typeVariables => throw new UnimplementedError();
- // TODO(ahe): Implement this method.
- List<TypeMirror> get typeArguments => throw new UnimplementedError();
+ List<TypeMirror> get typeArguments => const <TypeMirror>[];
karlklose 2014/09/19 10:39:51 Do you plan to create an InstantiatedJsTypedefMirr
floitsch 2014/09/19 11:42:09 They are needed by the createRuntimeType. Might be
- // TODO(ahe): Implement this method.
- bool get isOriginalDeclaration => throw new UnimplementedError();
+ bool get isOriginalDeclaration => true;
- // TODO(ahe): Implement this method.
- TypeMirror get originalDeclaration => throw new UnimplementedError();
+ TypeMirror get originalDeclaration => this;
- // TODO(ahe): Implement this method.
karlklose 2014/09/19 10:39:51 Restore TODO (with 'ahe' -> 'floitsch').
floitsch 2014/09/19 11:42:09 Done.
DeclarationMirror get owner => throw new UnimplementedError();
// TODO(ahe): Implement this method.
« no previous file with comments | « no previous file | tests/lib/mirrors/typedef_reflected_type_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698