dart2js: mirrors. Support Typedef.reflectedType.

sdk/lib/_internal/compiler/js_lib/js_mirrors.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart._js_mirrors;
 
 import 'shared/runtime_data.dart' as encoding;
 import 'shared/embedded_names.dart' show
     ALL_CLASSES,
     LAZIES,
@@ skipping 2500 matching lines @@
       : super(simpleName) {
     referent = new JsFunctionTypeMirror(_typeData, this);
   }
 
   JsFunctionTypeMirror get value => referent;
 
   String get _prettyName => 'TypedefMirror';
 
   bool get hasReflectedType => throw new UnimplementedError();
 
-  Type get reflectedType => throw new UnimplementedError();
+  Type get reflectedType => createRuntimeType(_mangledName);
 
-  // TODO(ahe): Implement this method.
+  // TODO(floitsch): Implement this method.
   List<TypeVariableMirror> get typeVariables => throw new UnimplementedError();
 
-  // TODO(ahe): Implement this method.
-  List<TypeMirror> get typeArguments => throw new UnimplementedError();
+  List<TypeMirror> get typeArguments => const <TypeMirror>[];

[karlklose, 2014/09/19 10:39:51]

Do you plan to create an InstantiatedJsTypedefMirror for typedefs with type
arguments?

Otherwise these three methods should probably stay unimplemented.

[floitsch, 2014/09/19 11:42:09]

They are needed by the createRuntimeType.
Might be thet JsTypeBoundTypedefMirror is what we want, but we can revisit when
we look at it.

 
-  // TODO(ahe): Implement this method.
-  bool get isOriginalDeclaration => throw new UnimplementedError();
+  bool get isOriginalDeclaration => true;
 
-  // TODO(ahe): Implement this method.
-  TypeMirror get originalDeclaration => throw new UnimplementedError();
+  TypeMirror get originalDeclaration => this;
 
-  // TODO(ahe): Implement this method.

[karlklose, 2014/09/19 10:39:51]

Restore TODO (with 'ahe' -> 'floitsch').

[floitsch, 2014/09/19 11:42:09]

Done.

   DeclarationMirror get owner => throw new UnimplementedError();
 
   // TODO(ahe): Implement this method.
   List<InstanceMirror> get metadata => throw new UnimplementedError();
 
   bool isSubtypeOf(TypeMirror other) => throw new UnimplementedError();
   bool isAssignableTo(TypeMirror other) => throw new UnimplementedError();
 }
 
 // TODO(ahe): Remove this class when API is updated.
@@ skipping 409 matching lines @@
   // have a part (following a '.') that starts with '_'.
   const int UNDERSCORE = 0x5f;
   if (name.isEmpty) return true;
   int index = -1;
   do {
     if (name.codeUnitAt(index + 1) == UNDERSCORE) return false;
     index = name.indexOf('.', index + 1);
   } while (index >= 0 && index + 1 < name.length);
   return true;
 }