Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 57923006: Devsite doc generation tweaks following Andy's requests. (Closed)

Created:
7 years, 1 month ago by eliben
Modified:
7 years, 1 month ago
Reviewers:
Sam Clegg, Andy
CC:
chromium-reviews, native-client-reviews_googlegroups.com, binji, Sam Clegg
Visibility:
Public.

Description

Devsite doc generation tweaks following Andy's requests. - Fix buggy path in Makefile and buggy template - Don't auto-generate Yaml TOCs for now, but copy over _book.yaml with proper substitutions. BUG=None R=sbc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232818

Patch Set 1 #

Total comments: 10

Patch Set 2 : remove debug printout #

Patch Set 3 : Sam's review #

Patch Set 4 : Remove YAML auto-generation code #

Patch Set 5 : leave a mention of auto-generating code in a comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -181 lines) Patch
M native_client_sdk/src/doc/Makefile View 1 chunk +1 line, -1 line 0 comments Download
A + native_client_sdk/src/doc/_book.yaml View 1 chunk +0 lines, -1 line 0 comments Download
D native_client_sdk/src/doc/_book_template.yaml View 1 chunk +0 lines, -7 lines 0 comments Download
M native_client_sdk/src/doc/_sphinxext/devsite_builder.py View 1 2 3 4 3 chunks +13 lines, -172 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
eliben
7 years, 1 month ago (2013-11-04 21:15:27 UTC) #1
Sam Clegg
https://codereview.chromium.org/57923006/diff/1/native_client_sdk/src/doc/_book.yaml File native_client_sdk/src/doc/_book.yaml (right): https://codereview.chromium.org/57923006/diff/1/native_client_sdk/src/doc/_book.yaml#newcode6 native_client_sdk/src/doc/_book.yaml:6: - include: /native-client/${folder}_reference_toc.yaml What not keep template in the ...
7 years, 1 month ago (2013-11-04 21:47:26 UTC) #2
eliben
https://codereview.chromium.org/57923006/diff/1/native_client_sdk/src/doc/_book.yaml File native_client_sdk/src/doc/_book.yaml (right): https://codereview.chromium.org/57923006/diff/1/native_client_sdk/src/doc/_book.yaml#newcode6 native_client_sdk/src/doc/_book.yaml:6: - include: /native-client/${folder}_reference_toc.yaml On 2013/11/04 21:47:26, Sam Clegg wrote: ...
7 years, 1 month ago (2013-11-04 21:53:02 UTC) #3
Sam Clegg
lgtm https://codereview.chromium.org/57923006/diff/1/native_client_sdk/src/doc/_book.yaml File native_client_sdk/src/doc/_book.yaml (right): https://codereview.chromium.org/57923006/diff/1/native_client_sdk/src/doc/_book.yaml#newcode6 native_client_sdk/src/doc/_book.yaml:6: - include: /native-client/${folder}_reference_toc.yaml On 2013/11/04 21:53:02, eliben wrote: ...
7 years, 1 month ago (2013-11-04 22:01:58 UTC) #4
eliben
7 years, 1 month ago (2013-11-04 22:27:30 UTC) #5
Message was sent while issue was closed.
Committed patchset #5 manually as r232818 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698