Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 579083003: Revert "Drop 10.5 support: use ServiceManagement.framework directly." (Closed)

Created:
6 years, 3 months ago by Mark Mentovai
Modified:
6 years, 3 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

Revert "Drop 10.5 support: use ServiceManagement.framework directly." This reverts commit 63fd3ae47d2513ef4390c3d8c0dde3fa95152480. SMJobRemove() still performs a 1-second sleep() when its |wait| parameter is true. Radar 18398683 is filed. In the mean time, the launchd-based implementation of these functions does not have this undesirable property. The comments have been revised to not reflect operating systems before Mac OS X 10.6. Comments describing bugs in earlier 10.10 seeds that have since been fixed have been removed. TEST=util_test Launchd.*:ServiceManagement.* R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/75988925f9161e4c339f3a02a1d8ed3e7d5a9018

Patch Set 1 #

Patch Set 2 : Use autorelease pools in the CFPropertyToLaunchData() tests #

Patch Set 3 : Use an autorelease pool in the CFPropertyToLaunchData() implementation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+590 lines, -80 lines) Patch
A util/mac/launchd.h View 1 chunk +39 lines, -0 lines 0 comments Download
A util/mac/launchd.mm View 1 2 1 chunk +141 lines, -0 lines 0 comments Download
A util/mac/launchd_test.mm View 1 1 chunk +303 lines, -0 lines 0 comments Download
M util/mac/service_management.h View 1 chunk +5 lines, -5 lines 0 comments Download
M util/mac/service_management.cc View 1 chunk +96 lines, -58 lines 0 comments Download
M util/mac/service_management_test.mm View 3 chunks +3 lines, -12 lines 0 comments Download
M util/util.gyp View 3 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
SMJobRemove() is still too buggy on 10.10. I could deal with the return value thing, ...
6 years, 3 months ago (2014-09-19 21:34:48 UTC) #2
Robert Sesek
LGTM, though I only reviewed the PS1 <> PS3 diffs
6 years, 3 months ago (2014-09-22 15:12:05 UTC) #3
Mark Mentovai
6 years, 3 months ago (2014-09-22 17:11:44 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:30001) manually as 7598892 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698