Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(899)

Unified Diff: util/mac/service_management.h

Issue 579083003: Revert "Drop 10.5 support: use ServiceManagement.framework directly." (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Use an autorelease pool in the CFPropertyToLaunchData() implementation Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « util/mac/launchd_test.mm ('k') | util/mac/service_management.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/mac/service_management.h
diff --git a/util/mac/service_management.h b/util/mac/service_management.h
index 743a5a01b04629071295cb2773a4457c404bea8c..802e5449e7a4d69dde6ff293e8c0c97d48afcee2 100644
--- a/util/mac/service_management.h
+++ b/util/mac/service_management.h
@@ -41,13 +41,13 @@ bool ServiceManagementSubmitJob(CFDictionaryRef job_cf);
//!
//! \return `true` if the job was removed successfully or if an asynchronous
//! attempt to remove the job was started successfully, otherwise `false`.
-//! Unlike previous systems, on Mac OS X 10.10, this function returns `true`
-//! even if \a label names a job that does not exist. This is filed as radar
-//! 18268941.
//!
//! \note This function is provided because `SMJobRemove()` is deprecated in Mac
-//! OS X 10.10. It may or may not be implemented using `SMJobRemove()` from
-//! `ServiceManagement.framework`.
+//! OS X 10.10. On Mac OS X 10.10, observed in DP8 14A361c, it also blocks
+//! for far too long (`_block_until_job_exits()` contains a one-second
+//! `sleep()`, filed as radar 18398683) and does not signal failure via its
+//! return value when asked to remove a nonexistent job (filed as radar
+//! 18268941).
bool ServiceManagementRemoveJob(const std::string& label, bool wait);
//! \brief Determines whether a specified job is loaded in the user launchd
« no previous file with comments | « util/mac/launchd_test.mm ('k') | util/mac/service_management.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698