Issue 579004: Pull latest googleurl to get various fixes

Issue 579004: Pull latest googleurl to get various fixes (Closed)

Created:
10 years, 10 months ago by brettw

Modified:
6 years ago

Reviewers:
Bernhard Bauer, Peter Kasting

CC:
chromium-reviews, darin (slow to review), Paweł Hajdan Jr., ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Pulls the latest googleurl to get the fix for BUG=http://crbug.com/160 and integrates the update to IsStandard in that version. Adds several internal schemes as "standard" and initializes them at startup. Fixes a few hardcoded URL schemes I noticed. Make typing "//foo" into the URL bar treat slashes in "strict" mode on Windows, which means we'll only accept UNC if you use backslashes. This matches IE's behavior. BUG=http://crbug.com/33038 TEST=covered by unit tests

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 3

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 1

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Patch Set 9 : '' #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -25 lines)			Patch
M	DEPS	View	5 6 7 8	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/app/chrome_dll_main.cc	View	4 5 6 7 8	2 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/child_process_security_policy.cc	View	4 5 6 7 8	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/dom_ui/chrome_url_data_manager.cc	View	5 6 7 8	1 chunk	+1 line, -4 lines	0 comments	Download
M	chrome/browser/extensions/extension_popup_api.cc	View	4 5 6 7 8	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_process_manager_unittest.cc	View	5 6 7 8	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/net/url_fixer_upper.cc	View	1 2 3 4 5 6 7 8	4 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/net/url_fixer_upper_unittest.cc	View	1 2 3 4 5 6 7 8	1 chunk	+9 lines, -1 line	0 comments	Download
M	chrome/chrome_common.gypi	View	6 7 8	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/url_constants.h	View	4 5 6 7 8	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/common/url_constants.cc	View	4 5 6 7 8	2 chunks	+8 lines, -0 lines	0 comments	Download
M	chrome/test/unit/chrome_test_suite.h	View	5 6 7 8	2 chunks	+2 lines, -0 lines	0 comments	Download
M	net/base/net_util_unittest.cc	View	5 6 7 8	1 chunk	+2 lines, -2 lines	0 comments	Download
M	net/url_request/request_tracker_unittest.cc	View	5 6 7 8	1 chunk	+10 lines, -8 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

brettw

This doesn't actually pull the latest googleurl yet since I haven't checked it in. The ...

10 years, 10 months ago (2010-02-05 20:53:57 UTC) #1

Peter Kasting

LGTM http://codereview.chromium.org/579004/diff/3001/4001 File chrome/browser/net/url_fixer_upper.cc (right): http://codereview.chromium.org/579004/diff/3001/4001#newcode1 chrome/browser/net/url_fixer_upper.cc:1: // Copyright (c) 2009 The Chromium Authors. All ...

10 years, 10 months ago (2010-02-05 21:03:35 UTC) #2

brettw

Darin/Bernhard: This is the Chrome side of the googleurl change. I added registering the chrome ...

10 years, 10 months ago (2010-02-08 18:35:17 UTC) #3

bauerb at google

http://codereview.chromium.org/579004/diff/6001/7004 File chrome/common/url_constants.h (right): http://codereview.chromium.org/579004/diff/6001/7004#newcode84 chrome/common/url_constants.h:84: // Call near the begging of startup to register ...

10 years, 10 months ago (2010-02-08 18:45:48 UTC) #4

brettw

10 years, 10 months ago (2010-02-12 21:24:33 UTC) #5

New snap up including some fixes from bauerb and some I found that the unit
tests pointed out. I'll need to sync this with a WebKit roll when I land.

Expand Messages | Collapse Messages