Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Unified Diff: chrome/browser/net/url_fixer_upper_unittest.cc

Issue 579004: Pull latest googleurl to get various fixes (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/net/url_fixer_upper.cc ('k') | chrome/chrome_common.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/net/url_fixer_upper_unittest.cc
===================================================================
--- chrome/browser/net/url_fixer_upper_unittest.cc (revision 40415)
+++ chrome/browser/net/url_fixer_upper_unittest.cc (working copy)
@@ -342,8 +342,16 @@
// should be returned just converted to a file: URL.
{"\\\\SomeNonexistentHost\\foo\\bar.txt", "",
"file://somenonexistenthost/foo/bar.txt"},
+ // We do this strictly, like IE8, which only accepts this form using
+ // backslashes and not forward ones. Its a bit weird that the host/path is
+ // "more canonicalized" in the UNC case above, and in the http case it
+ // isn't lowercased, etc. That level of canonicalization will happen when
+ // it's actually turned into a GURL, so we don't care about it here. Turning
+ // "//foo" into "http" matches Firefox and IE, silly though it may seem
+ // (it falls out of adding "http" as the default protocol if you haven't
+ // entered one).
{"//SomeNonexistentHost\\foo/bar.txt", "",
- "file://somenonexistenthost/foo/bar.txt"},
+ "http://SomeNonexistentHost\\foo/bar.txt"},
{"file:///C:/foo/bar", "", "file:///C:/foo/bar"},
// These are fixups we don't do, but could consider:
« no previous file with comments | « chrome/browser/net/url_fixer_upper.cc ('k') | chrome/chrome_common.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698