Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(885)

Unified Diff: chrome/browser/notifications/notification_object_proxy.h

Issue 578883003: Remove the strict dependency on WebContents for Web Notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/notification_object_proxy.h
diff --git a/chrome/browser/notifications/notification_object_proxy.h b/chrome/browser/notifications/notification_object_proxy.h
index ea8c8ae31dfeb8c4726a584ec9a3405fd01b8e90..5035b4f62c4dfcf2f49e52889d47e71780344161 100644
--- a/chrome/browser/notifications/notification_object_proxy.h
+++ b/chrome/browser/notifications/notification_object_proxy.h
@@ -12,7 +12,6 @@
namespace content {
class DesktopNotificationDelegate;
-class RenderFrameHost;
}
// A NotificationObjectProxy stands in for the JavaScript Notification object
@@ -25,7 +24,6 @@ class NotificationObjectProxy
// Creates a Proxy object with the necessary callback information. The Proxy
// will take ownership of |delegate|.
NotificationObjectProxy(
- content::RenderFrameHost* render_frame_host,
scoped_ptr<content::DesktopNotificationDelegate> delegate);
// NotificationDelegate implementation.
@@ -37,14 +35,9 @@ class NotificationObjectProxy
virtual content::WebContents* GetWebContents() const OVERRIDE;
protected:
- friend class base::RefCountedThreadSafe<NotificationObjectProxy>;
-
virtual ~NotificationObjectProxy();
private:
- // Callback information to find the JS Notification object where it lives.
- int render_process_id_;
- int render_frame_id_;
scoped_ptr<content::DesktopNotificationDelegate> delegate_;
bool displayed_;
std::string id_;

Powered by Google App Engine
This is Rietveld 408576698