Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4567)

Unified Diff: chrome/browser/notifications/notification_object_proxy.cc

Issue 578883003: Remove the strict dependency on WebContents for Web Notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/notification_object_proxy.cc
diff --git a/chrome/browser/notifications/notification_object_proxy.cc b/chrome/browser/notifications/notification_object_proxy.cc
index a21b4c0bf6290b24444fd94e2bf224a4cd0dbdd0..a6aa055634350d96377a37c171660993445405e4 100644
--- a/chrome/browser/notifications/notification_object_proxy.cc
+++ b/chrome/browser/notifications/notification_object_proxy.cc
@@ -5,21 +5,13 @@
#include "chrome/browser/notifications/notification_object_proxy.h"
#include "base/guid.h"
-#include "base/strings/stringprintf.h"
#include "content/public/browser/desktop_notification_delegate.h"
-#include "content/public/browser/render_frame_host.h"
-#include "content/public/browser/render_process_host.h"
-#include "content/public/browser/web_contents.h"
NotificationObjectProxy::NotificationObjectProxy(
- content::RenderFrameHost* render_frame_host,
scoped_ptr<content::DesktopNotificationDelegate> delegate)
- : render_process_id_(render_frame_host->GetProcess()->GetID()),
- render_frame_id_(render_frame_host->GetRoutingID()),
- delegate_(delegate.Pass()),
+ : delegate_(delegate.Pass()),
displayed_(false),
- id_(base::GenerateGUID()) {
-}
+ id_(base::GenerateGUID()) {}
NotificationObjectProxy::~NotificationObjectProxy() {}
@@ -50,6 +42,5 @@ std::string NotificationObjectProxy::id() const {
}
content::WebContents* NotificationObjectProxy::GetWebContents() const {
- return content::WebContents::FromRenderFrameHost(
- content::RenderFrameHost::FromID(render_process_id_, render_frame_id_));
+ return NULL;
}

Powered by Google App Engine
This is Rietveld 408576698