Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Issue 578843002: cc: Return a NullCanvas instead of NULL in context lost situations. (Closed)

Created:
6 years, 3 months ago by reveman
Modified:
6 years, 3 months ago
Reviewers:
vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cc: Return a NullCanvas instead of NULL in context lost situations. This reduces the difference in code paths between normal usage and context lost situations. Also moves the save()/restore() pair required for GPU raster into the RasterBuffer class so it can be avoided when unnecessary. BUG=406404 Committed: https://crrev.com/102706b5cedfa35c68069f185a4f8c187d485722 Cr-Commit-Position: refs/heads/master@{#295290}

Patch Set 1 #

Patch Set 2 : update unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -10 lines) Patch
M cc/resources/resource_provider.cc View 5 chunks +10 lines, -4 lines 0 comments Download
M cc/resources/resource_provider_unittest.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M cc/resources/tile_manager.cc View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
reveman
6 years, 3 months ago (2014-09-17 14:18:02 UTC) #2
vmpstr
lgtm
6 years, 3 months ago (2014-09-17 15:26:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/578843002/20001
6 years, 3 months ago (2014-09-17 15:30:18 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 1daf9f1d4b376d9a8cd4b9534560bb3399829239
6 years, 3 months ago (2014-09-17 17:20:05 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 17:20:42 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/102706b5cedfa35c68069f185a4f8c187d485722
Cr-Commit-Position: refs/heads/master@{#295290}

Powered by Google App Engine
This is Rietveld 408576698