cc/resources/resource_provider_unittest.cc - Issue 578843002: cc: Return a NullCanvas instead of NULL in context lost situations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/resources/resource_provider_unittest.cc

Issue 578843002: cc: Return a NullCanvas instead of NULL in context lost situations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update unit test Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/resources/resource_provider_unittest.cc

diff --git a/cc/resources/resource_provider_unittest.cc b/cc/resources/resource_provider_unittest.cc

index e10e01ccdcac04db9c6d429deee0350995bf2e51..3496cfe6d6dea91d193eb1b4bf0b5eed22e7ee86 100644

--- a/cc/resources/resource_provider_unittest.cc

+++ b/cc/resources/resource_provider_unittest.cc

@@ -3323,9 +3323,8 @@ TEST_P(ResourceProviderTest, PixelBufferLostContext) {

RasterBuffer* raster_buffer = resource_provider->AcquirePixelRasterBuffer(id);

skia::RefPtr<SkCanvas> canvas = raster_buffer->AcquireSkCanvas();

- EXPECT_TRUE(canvas.get() == NULL);

+ EXPECT_TRUE(canvas);

raster_buffer->ReleaseSkCanvas(canvas);

- canvas.clear();

resource_provider->ReleasePixelRasterBuffer(id);

Mock::VerifyAndClearExpectations(context);

}

« no previous file with comments | « cc/resources/resource_provider.cc ('k') | cc/resources/tile_manager.cc » ('j') | no next file with comments »