Issue 5788001: ARM: Fix heap number allocation in lithium-codegen-arm that assumed...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5788001: ARM: Fix heap number allocation in lithium-codegen-arm that assumed... (Closed)

Created:
10 years ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

ARM: Fix heap number allocation in lithium-codegen-arm that assumed that ip can be used as a scratch register. This is not true because ip is already used for something else in AllocateInNewSpace in the macro assembler. Explicitly allocate a temp register for use in the heap number allocation instead. Committed: http://code.google.com/p/v8/source/detail?r=5967

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -9 lines)			Patch
M	src/arm/lithium-arm.h	View		1 chunk	+6 lines, -4 lines	0 comments	Download
M	src/arm/lithium-arm.cc	View		1 chunk	+5 lines, -3 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/arm/macro-assembler-arm.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

lgtm http://codereview.chromium.org/5788001/diff/1/src/arm/lithium-arm.h File src/arm/lithium-arm.h (right): http://codereview.chromium.org/5788001/diff/1/src/arm/lithium-arm.h#newcode1398 src/arm/lithium-arm.h:1398: explicit LNumberTagD(LOperand* value, LOperand* temp1, LOperand* temp2) No ...

10 years ago (2010-12-10 14:06:26 UTC) #2

Mads Ager (chromium)

10 years ago (2010-12-10 14:12:58 UTC) #4

On 2010/12/10 14:11:58, Mads Ager wrote:
> LGTM

Well, d'oh! Otherwise I wouldn't have uploaded the thing. ;)

What I meant to say was that I removed the explicit! Thanks!

Expand Messages | Collapse Messages