Chromium Code Reviews
Help | Chromium Project | Sign in
(270)

Issue 5788001: ARM: Fix heap number allocation in lithium-codegen-arm that assumed... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 4 months ago by Mads Ager (chromium)
Modified:
2 years, 11 months ago
Reviewers:
Erik Corry
CC:
v8-dev_googlegroups.com
Visibility:
Public.

Description

ARM: Fix heap number allocation in lithium-codegen-arm that assumed
that ip can be used as a scratch register. This is not true because
ip is already used for something else in AllocateInNewSpace in the
macro assembler.

Explicitly allocate a temp register for use in the heap number
allocation instead.

Committed: http://code.google.com/p/v8/source/detail?r=5967

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -9 lines) Lint Patch
M src/arm/lithium-arm.h View 1 chunk +6 lines, -4 lines 0 comments 0 errors Download
M src/arm/lithium-arm.cc View 1 chunk +5 lines, -3 lines 0 comments 0 errors Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +3 lines, -2 lines 0 comments 0 errors Download
M src/arm/macro-assembler-arm.cc View 1 1 chunk +5 lines, -0 lines 0 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 4
Mads Ager (chromium)
3 years, 4 months ago #1
Erik Corry
lgtm http://codereview.chromium.org/5788001/diff/1/src/arm/lithium-arm.h File src/arm/lithium-arm.h (right): http://codereview.chromium.org/5788001/diff/1/src/arm/lithium-arm.h#newcode1398 src/arm/lithium-arm.h:1398: explicit LNumberTagD(LOperand* value, LOperand* temp1, LOperand* temp2) No ...
3 years, 4 months ago #2
Mads Ager (chromium)
LGTM
3 years, 4 months ago #3
Mads Ager (chromium)
3 years, 4 months ago #4
On 2010/12/10 14:11:58, Mads Ager wrote:
> LGTM

Well, d'oh! Otherwise I wouldn't have uploaded the thing. ;)

What I meant to say was that I removed the explicit! Thanks!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6