Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 578703003: use base::Time constants in net module instead of using static constants (Closed)

Created:
6 years, 3 months ago by prashant.hiremath
Modified:
6 years, 3 months ago
Reviewers:
Ryan Hamilton, davidben
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

use base::Time constants in net module instead of using static constants use base::Time constants in net module instead of using static constants in file BUG=412254 Committed: https://crrev.com/d22b4a8eb8ef778afbc80a03d4b45f2e3b87e2df Cr-Commit-Position: refs/heads/master@{#295292}

Patch Set 1 #

Total comments: 2

Patch Set 2 : changed as per review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M net/dns/mdns_client_impl.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
prashant.hiremath
Please Review
6 years, 3 months ago (2014-09-17 02:45:47 UTC) #2
davidben
Looks good with a couple nits. It looks like you've signed the individual CLA, but ...
6 years, 3 months ago (2014-09-17 13:32:00 UTC) #3
prashant.hiremath
On 2014/09/17 13:32:00, David Benjamin wrote: > Looks good with a couple nits. > > ...
6 years, 3 months ago (2014-09-17 15:25:42 UTC) #4
davidben
On 2014/09/17 15:25:42, prashant.hiremath wrote: > hi David, Cisco has already signed the Corporate CLA, ...
6 years, 3 months ago (2014-09-17 16:04:40 UTC) #5
prashant.hiremath
PTAL
6 years, 3 months ago (2014-09-17 16:16:59 UTC) #6
davidben
lgtm. Thanks!
6 years, 3 months ago (2014-09-17 16:22:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/578703003/20001
6 years, 3 months ago (2014-09-17 16:25:35 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 9e6133128703c16c9821e4b14440a2b565991718
6 years, 3 months ago (2014-09-17 17:27:35 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 17:28:09 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d22b4a8eb8ef778afbc80a03d4b45f2e3b87e2df
Cr-Commit-Position: refs/heads/master@{#295292}

Powered by Google App Engine
This is Rietveld 408576698