use base::Time constants in net module instead of using static constants

net/dns/mdns_client_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/dns/mdns_client_impl.h"
 
 #include "base/bind.h"
 #include "base/message_loop/message_loop_proxy.h"
 #include "base/stl_util.h"
 #include "base/time/default_clock.h"

[davidben, 2014/09/17 13:32:00]

Nit: This should
  #include "base/time/time.h"
since you're using a constant from there directly. (Really should have been
included already for base::Time and base::TimeDelta.)

 #include "net/base/dns_util.h"
 #include "net/base/net_errors.h"
 #include "net/base/net_log.h"
 #include "net/base/rand_callback.h"
 #include "net/dns/dns_protocol.h"
 #include "net/dns/record_rdata.h"
 #include "net/udp/datagram_socket.h"
 
 // TODO(gene): Remove this temporary method of disabling NSEC support once it
 // becomes clear whether this feature should be
 // supported. http://crbug.com/255232
 #define ENABLE_NSEC
 
 namespace net {
 
 namespace {
 
 const unsigned MDnsTransactionTimeoutSeconds = 3;
 // The fractions of the record's original TTL after which an active listener
 // (one that had |SetActiveRefresh(true)| called) will send a query to refresh
 // its cache. This happens both at 85% of the original TTL and again at 95% of
 // the original TTL.
 const double kListenerRefreshRatio1 = 0.85;
 const double kListenerRefreshRatio2 = 0.95;
-const unsigned kMillisecondsPerSecond = 1000;
-

[davidben, 2014/09/17 13:32:00]

Really nitpicky nit: I would leave the blank line since the one on line 27 is
still there.

 }  // namespace
 
 void MDnsSocketFactoryImpl::CreateSockets(
     ScopedVector<DatagramServerSocket>* sockets) {
   InterfaceIndexFamilyList interfaces(GetMDnsInterfacesToBind());
   for (size_t i = 0; i < interfaces.size(); ++i) {
     DCHECK(interfaces[i].second == net::ADDRESS_FAMILY_IPV4 ||
            interfaces[i].second == net::ADDRESS_FAMILY_IPV6);
     scoped_ptr<DatagramServerSocket> socket(
         CreateAndBindMDnsSocket(interfaces[i].second, interfaces[i].first));
@@ skipping 484 matching lines @@
     return;
   }
 
   next_refresh_.Reset(base::Bind(&MDnsListenerImpl::DoRefresh,
                                  AsWeakPtr()));
 
   // Schedule refreshes at both 85% and 95% of the original TTL. These will both
   // be canceled and rescheduled if the record's TTL is updated due to a
   // response being received.
   base::Time next_refresh1 = last_update_ + base::TimeDelta::FromMilliseconds(
-      static_cast<int>(kMillisecondsPerSecond *
+      static_cast<int>(base::Time::kMillisecondsPerSecond *
                        kListenerRefreshRatio1 * ttl_));
 
   base::Time next_refresh2 = last_update_ + base::TimeDelta::FromMilliseconds(
-      static_cast<int>(kMillisecondsPerSecond *
+      static_cast<int>(base::Time::kMillisecondsPerSecond *
                        kListenerRefreshRatio2 * ttl_));
 
   base::MessageLoop::current()->PostDelayedTask(
       FROM_HERE,
       next_refresh_.callback(),
       next_refresh1 - base::Time::Now());
 
   base::MessageLoop::current()->PostDelayedTask(
       FROM_HERE,
       next_refresh_.callback(),
@@ skipping 145 matching lines @@
 
 void MDnsTransactionImpl::OnNsecRecord(const std::string& name, unsigned type) {
   TriggerCallback(RESULT_NSEC, NULL);
 }
 
 void MDnsTransactionImpl::OnCachePurged() {
   // TODO(noamsml): Cache purge situations not yet implemented
 }
 
 }  // namespace net