mac: Only show the access Address Book prompt a fixed number of times.

components/autofill/core/browser/personal_data_manager_mac.mm

Index: components/autofill/core/browser/personal_data_manager_mac.mm
diff --git a/components/autofill/core/browser/personal_data_manager_mac.mm b/components/autofill/core/browser/personal_data_manager_mac.mm
index c6f8eef8b0205bce729cdcf3c88c53aed5e7530b..b457e8b464cf9f7b2f0ae997a7758e3e92f22350 100644
--- a/components/autofill/core/browser/personal_data_manager_mac.mm
+++ b/components/autofill/core/browser/personal_data_manager_mac.mm
@@ -31,6 +31,10 @@
 namespace autofill {
 namespace {
 
+// The maximum number of instances when the access Address Book prompt should
+// be shown.
+int kMaxTimesToShowMacAddressBookCount = 5;

[Evan Stade, 2014/09/18 21:26:37]

nit: "Times" and "Count" seem redundant

[erikchen, 2014/09/18 21:55:57]

Changed to kMaxTimesToShowMacAddressBook

+
 // There is an uncommon sequence of events that causes the Address Book
 // permissions dialog to appear more than once for a given install of Chrome.
 //  1. Chrome has previously presented the Address Book permissions dialog.
@@ -374,6 +378,10 @@ bool PersonalDataManager::ShouldShowAccessAddressBookSuggestion(
   if (HasPromptedForAccessToAddressBook(pref_service_))
     return false;
 
+  if (pref_service_->GetInteger(prefs::kAutofillMacAddressBookShowedCount) >=
+      kMaxTimesToShowMacAddressBookCount)

[Evan Stade, 2014/09/18 21:26:37]

nit: 4 more indent

[erikchen, 2014/09/18 21:55:57]

Doesn't apply anymore, since conditional fits on a single line.

For reference, this indentation is the output of clang-format. It also matches
the indentation of the other conditionals in this file. e.g. lines 321-367 have
multiple examples of this. 

+    return false;

[Evan Stade, 2014/09/18 21:26:37]

nit: curlies

[erikchen, 2014/09/18 21:55:57]

N/A

+
   switch (type.group()) {
     case ADDRESS_BILLING:
     case ADDRESS_HOME:
@@ -394,6 +402,13 @@ bool PersonalDataManager::ShouldShowAccessAddressBookSuggestion(
   return false;
 }
 
+void PersonalDataManager::ShowedAccessAddressBookPrompt() {
+  int count =
+      pref_service_->GetInteger(prefs::kAutofillMacAddressBookShowedCount);
+  pref_service_->SetInteger(prefs::kAutofillMacAddressBookShowedCount,
+                            count + 1);
+}
+
 void PersonalDataManager::BinaryChanging() {
   g_binary_changed = true;
 }