mac: Only show the access Address Book prompt a fixed number of times.

components/autofill/core/browser/personal_data_manager_mac.mm

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/personal_data_manager.h"
 
 #include <math.h>
 
 #import <AddressBook/AddressBook.h>
 
@@ skipping 13 matching lines @@
 #include "components/autofill/core/browser/form_structure.h"
 #include "components/autofill/core/browser/phone_number.h"
 #include "components/autofill/core/common/autofill_pref_names.h"
 #include "components/autofill/core/common/form_data.h"
 #include "grit/components_strings.h"
 #include "ui/base/l10n/l10n_util_mac.h"
 
 namespace autofill {
 namespace {
 
+// The maximum number of instances when the access Address Book prompt should
+// be shown.
+int kMaxTimesToShowMacAddressBookCount = 5;

[Evan Stade, 2014/09/18 21:26:37]

nit: "Times" and "Count" seem redundant

[erikchen, 2014/09/18 21:55:57]

Changed to kMaxTimesToShowMacAddressBook

+
 // There is an uncommon sequence of events that causes the Address Book
 // permissions dialog to appear more than once for a given install of Chrome.
 //  1. Chrome has previously presented the Address Book permissions dialog.
 //  2. Chrome is launched.
 //  3. Chrome performs an auto-update, and changes its binary.
 //  4. Chrome attempts to access the Address Book for the first time since (2).
 // This sequence of events is rare because Chrome attempts to acess the Address
 // Book when the user focuses most form fields, so (4) generally occurs before
 // (3). For more details, see http://crbug.com/381763.
 //
@@ skipping 323 matching lines @@
   // Autofill state.
   if (!web_profiles_.empty())
     return false;
 
   if (!enabled_pref_->GetValue())
     return false;
 
   if (HasPromptedForAccessToAddressBook(pref_service_))
     return false;
 
+  if (pref_service_->GetInteger(prefs::kAutofillMacAddressBookShowedCount) >=
+      kMaxTimesToShowMacAddressBookCount)

[Evan Stade, 2014/09/18 21:26:37]

nit: 4 more indent

[erikchen, 2014/09/18 21:55:57]

Doesn't apply anymore, since conditional fits on a single line.

For reference, this indentation is the output of clang-format. It also matches
the indentation of the other conditionals in this file. e.g. lines 321-367 have
multiple examples of this. 

+    return false;

[Evan Stade, 2014/09/18 21:26:37]

nit: curlies

[erikchen, 2014/09/18 21:55:57]

N/A

+
   switch (type.group()) {
     case ADDRESS_BILLING:
     case ADDRESS_HOME:
     case EMAIL:
     case NAME:
     case NAME_BILLING:
     case PHONE_BILLING:
     case PHONE_HOME:
       return true;
     case NO_GROUP:
     case COMPANY:
     case CREDIT_CARD:
     case PASSWORD_FIELD:
     case TRANSACTION:
       return false;
   }
 
   return false;
 }
 
+void PersonalDataManager::ShowedAccessAddressBookPrompt() {
+  int count =
+      pref_service_->GetInteger(prefs::kAutofillMacAddressBookShowedCount);
+  pref_service_->SetInteger(prefs::kAutofillMacAddressBookShowedCount,
+                            count + 1);
+}
+
 void PersonalDataManager::BinaryChanging() {
   g_binary_changed = true;
 }
 
 }  // namespace autofill