Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 578253002: Add missing parenthesis in FXARGB_GETDIB macro (Closed)

Created:
6 years, 3 months ago by Jiang Jiang
Modified:
6 years, 2 months ago
Reviewers:
Bo Xu, Nico, jam
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Visibility:
Public.

Description

Add missing parenthesis in FXARGB_GETDIB macro You can get warning when using FXARGB_GETDIB() with & operation in the same statement like: FXARGB_GETDIB(src_scan) & 0xffffff in fx_dib_composite.cpp: ../../third_party/pdfium/core/src/fxge/dib/fx_dib_composite.cpp:737:205: error: '&' within '|' [-Werror,-Wbitwise-op-parentheses] Original patch from jiangj@opera.com

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M core/include/fxge/fx_dib.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (5 generated)
Jiang Jiang
6 years, 3 months ago (2014-09-18 09:21:26 UTC) #2
Jiang Jiang
6 years, 2 months ago (2014-10-01 17:29:29 UTC) #4
Nico
lgtm The warning is a true positive for the snippet you pasted, right?
6 years, 2 months ago (2014-10-01 22:13:48 UTC) #5
Nico
6 years, 2 months ago (2014-10-01 22:14:37 UTC) #7
Jiang Jiang
6 years, 2 months ago (2014-10-03 17:18:56 UTC) #8
Jiang Jiang
On 2014/10/01 22:13:48, Nico (away until Oct 27) wrote: > lgtm > > The warning ...
6 years, 2 months ago (2014-10-03 17:19:15 UTC) #9
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
6 years, 2 months ago (2014-10-03 17:21:15 UTC) #12
Bo Xu
On 2014/10/03 17:18:56, Jiang Jiang wrote: This has to be committed manually via "git cl ...
6 years, 2 months ago (2014-10-03 17:24:00 UTC) #13
Jiang Jiang
On 2014/10/03 17:24:00, Bo Xu wrote: > On 2014/10/03 17:18:56, Jiang Jiang wrote: > > ...
6 years, 2 months ago (2014-10-03 17:31:30 UTC) #14
Bo Xu
On 2014/10/03 17:31:30, Jiang Jiang wrote: > On 2014/10/03 17:24:00, Bo Xu wrote: > > ...
6 years, 2 months ago (2014-10-03 17:34:20 UTC) #15
jam
On 2014/10/03 17:34:20, Bo Xu wrote: > On 2014/10/03 17:31:30, Jiang Jiang wrote: > > ...
6 years, 2 months ago (2014-10-15 16:03:37 UTC) #16
Bo Xu
On 2014/10/15 16:03:37, jam wrote: > On 2014/10/03 17:34:20, Bo Xu wrote: > > On ...
6 years, 2 months ago (2014-10-15 17:36:54 UTC) #17
Jiang Jiang
On 2014/10/15 17:36:54, Bo Xu wrote: > On 2014/10/15 16:03:37, jam wrote: > > On ...
6 years, 2 months ago (2014-10-15 17:58:56 UTC) #18
Bo Xu
6 years, 2 months ago (2014-10-21 19:06:36 UTC) #19
I have committed in
https://pdfium.googlesource.com/pdfium/+/f71c2d02294fb3ceb7b19a93a6913f97c4ff....
@Jiang, you can close this issue. Thanks.

Powered by Google App Engine
This is Rietveld 408576698