|
|
Created:
6 years, 3 months ago by Jiang Jiang Modified:
6 years, 2 months ago CC:
pdfium-reviews_googlegroups.com Base URL:
https://pdfium.googlesource.com/pdfium.git@master Visibility:
Public. |
DescriptionAdd missing parenthesis in FXARGB_GETDIB macro
You can get warning when using FXARGB_GETDIB() with & operation in
the same statement like: FXARGB_GETDIB(src_scan) & 0xffffff in
fx_dib_composite.cpp:
../../third_party/pdfium/core/src/fxge/dib/fx_dib_composite.cpp:737:205:
error: '&' within '|' [-Werror,-Wbitwise-op-parentheses]
Original patch from jiangj@opera.com
Patch Set 1 #
Messages
Total messages: 19 (5 generated)
jiangj@opera.com changed reviewers: + jabdelmalek@google.com
jiangj@opera.com changed reviewers: + jam@chromium.org, thakis@chromium.org - jabdelmalek@google.com
lgtm The warning is a true positive for the snippet you pasted, right?
thakis@chromium.org changed reviewers: + bo_xu@foxitsoftware.com
On 2014/10/01 22:13:48, Nico (away until Oct 27) wrote: > lgtm > > The warning is a true positive for the snippet you pasted, right? Yes, it's a true positive.
The CQ bit was checked by jiangj@opera.com
The CQ bit was unchecked by commit-bot@chromium.org
Commit queue rejected this change because it did not recognize the base URL. Please commit your change manually.
On 2014/10/03 17:18:56, Jiang Jiang wrote: This has to be committed manually via "git cl land"
On 2014/10/03 17:24:00, Bo Xu wrote: > On 2014/10/03 17:18:56, Jiang Jiang wrote: > > This has to be committed manually via "git cl land" I'm not a committer, can you please do it for me?
On 2014/10/03 17:31:30, Jiang Jiang wrote: > On 2014/10/03 17:24:00, Bo Xu wrote: > > On 2014/10/03 17:18:56, Jiang Jiang wrote: > > > > This has to be committed manually via "git cl land" > > I'm not a committer, can you please do it for me? @Jam, can you grant the permission for Jiang? Thanks.
On 2014/10/03 17:34:20, Bo Xu wrote: > On 2014/10/03 17:31:30, Jiang Jiang wrote: > > On 2014/10/03 17:24:00, Bo Xu wrote: > > > On 2014/10/03 17:18:56, Jiang Jiang wrote: > > > > > > This has to be committed manually via "git cl land" > > > > I'm not a committer, can you please do it for me? > > @Jam, can you grant the permission for Jiang? Thanks. if it's just one patch, Bo do you mind landing it? Also add Jiang to the AUTHORS file in pdfium, thanks.
On 2014/10/15 16:03:37, jam wrote: > On 2014/10/03 17:34:20, Bo Xu wrote: > > On 2014/10/03 17:31:30, Jiang Jiang wrote: > > > On 2014/10/03 17:24:00, Bo Xu wrote: > > > > On 2014/10/03 17:18:56, Jiang Jiang wrote: > > > > > > > > This has to be committed manually via "git cl land" > > > > > > I'm not a committer, can you please do it for me? > > > > @Jam, can you grant the permission for Jiang? Thanks. > > if it's just one patch, Bo do you mind landing it? Also add Jiang to the AUTHORS > file in pdfium, thanks. Sure. @Jiang Jiang, can you add a line at the end of the description, say "Original patch from jiangj@opera.com", since I am going to land this for you. Thanks.
On 2014/10/15 17:36:54, Bo Xu wrote: > On 2014/10/15 16:03:37, jam wrote: > > On 2014/10/03 17:34:20, Bo Xu wrote: > > > On 2014/10/03 17:31:30, Jiang Jiang wrote: > > > > On 2014/10/03 17:24:00, Bo Xu wrote: > > > > > On 2014/10/03 17:18:56, Jiang Jiang wrote: > > > > > > > > > > This has to be committed manually via "git cl land" > > > > > > > > I'm not a committer, can you please do it for me? > > > > > > @Jam, can you grant the permission for Jiang? Thanks. > > > > if it's just one patch, Bo do you mind landing it? Also add Jiang to the > AUTHORS > > file in pdfium, thanks. > > Sure. @Jiang Jiang, can you add a line at the end of the description, say > "Original patch from mailto:jiangj@opera.com", since I am going to land this for you. > Thanks. Thanks, done.
I have committed in https://pdfium.googlesource.com/pdfium/+/f71c2d02294fb3ceb7b19a93a6913f97c4ff.... @Jiang, you can close this issue. Thanks. |